From: Greg KH <greg@kroah.com>
To: stefan.eletzhofer@eletztrick.de,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] 2.6 I2C re-add i2c_get_client()
Date: Sat, 1 May 2004 23:01:09 -0700 [thread overview]
Message-ID: <20040502060109.GF31886@kroah.com> (raw)
In-Reply-To: <20040429140657.GC23468@gonzo.local>
On Thu, Apr 29, 2004 at 04:06:57PM +0200, stefan.eletzhofer@eletztrick.de wrote:
> Hi,
> here's a patch which re-adds i2c_get_client() back to i2c_core.c.
> That call was removed in 2003 because there were no users of that
> function at that time.
>
> I think this call is needed for I2C chip drivers which provide functionality to
> be used by other driver modules, for example RTC chips or EEPROMs. These chip
> drivers tend to encapsulate raw i2c chip access and provide function calls
> for other modulesi, for example via the i2c_driver->command() method.
>
> I tried to get the locking right, so please comment. The patch is
> against 2.6.6-rc3 and works quite fine with my i2c rtc chip.
Locking looks correct, but you also need to increment either the
device's reference count, and/or the module reference count for the
client.
Care to fix that up?
thanks,
greg k-h
next prev parent reply other threads:[~2004-05-02 6:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-29 14:06 [PATCH] 2.6 I2C re-add i2c_get_client() stefan.eletzhofer
2004-05-02 6:01 ` Greg KH [this message]
2004-05-02 15:08 ` stefan.eletzhofer
2004-05-07 22:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040502060109.GF31886@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefan.eletzhofer@eletztrick.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox