public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Andrew Morton <akpm@osdl.org>,
	vandrove@vc.cvut.cz, cw@f00f.org, koke@amedias.org,
	linux-kernel@vger.kernel.org
Subject: Re: strange delays on console logouts (tty != 1)
Date: Sun, 2 May 2004 11:17:29 +0100	[thread overview]
Message-ID: <20040502111729.D9605@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20040502103721.C9605@flint.arm.linux.org.uk>; from rmk+lkml@arm.linux.org.uk on Sun, May 02, 2004 at 10:37:21AM +0100

On Sun, May 02, 2004 at 10:37:21AM +0100, Russell King wrote:
> On Sun, May 02, 2004 at 09:17:51AM +0100, Russell King wrote:
> > > If so, how is tty_hangup() getting involved?
> > 
> > The only way it could be invoked is via SAK, which obviously isn't
> > happening here.
> > 
> > However, login _does_ call sys_vhangup() which in turn calls tty_vhangup()
> > so I suspect that the statement "tty hangup is scheduled for work_queue"
> > is based on the _assumption_ that sys_vhangup() calls tty_hangup()
> > rather than the function it actually does.
> 
> Ok, the VT_OPENQRY crap is a debian modification to agetty.  As far as
> I can see, there is no code in agetty which calls sys_vhangup().

And a further follow-up...

Looking in the debian bug system reveals these two bugs:

     * #216658: getty: opens tty without checking if something else is there,
       killing keyboard input
     * #226443: util-linux: [getty] Logout is really long with kernel 2.6

The first one is of particular note, because it is the cause of the GROSS
hack in agetty, which according to the comments is also in gdm.

I wonder really if the problem was elsewhere, and if Debian wanted to
take care of this problem, why they didn't just take the serial line
locking solution (really: s/serial line/tty/) and apply it to
agetty / gdm.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

  reply	other threads:[~2004-05-02 10:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-30 19:53 strange delays on console logouts (tty != 1) Jorge Bernal
2004-05-01 21:46 ` Chris Wedgwood
2004-05-01 23:24   ` Petr Vandrovec
2004-05-01 23:44     ` Chris Wedgwood
2004-05-02  0:36       ` Petr Vandrovec
2004-05-02  0:45         ` Chris Wedgwood
2004-05-02 13:54       ` Andries Brouwer
2004-05-02  1:03     ` Andrew Morton
2004-05-02  8:00       ` Russell King
2004-05-02  8:13         ` Andrew Morton
2004-05-02  8:17           ` Russell King
2004-05-02  9:37             ` Russell King
2004-05-02 10:17               ` Russell King [this message]
2004-05-02 12:01                 ` Petr Vandrovec
2004-05-02 17:53                 ` Chris Wedgwood
2004-05-02 18:01                   ` Russell King
2004-05-02 18:19                     ` Chris Wedgwood
2004-05-02 18:04                   ` Russell King
2004-05-01 22:20 ` Chris Wedgwood
2004-05-02  0:26   ` Jorge Bernal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040502111729.D9605@flint.arm.linux.org.uk \
    --to=rmk+lkml@arm.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=cw@f00f.org \
    --cc=koke@amedias.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vandrove@vc.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox