From: Greg Banks <gnb@sgi.com>
To: Neil Brown <neilb@cse.unsw.edu.au>
Cc: Greg Banks <gnb@melbourne.sgi.com>,
Nikita Danilov <Nikita@Namesys.COM>,
linux kernel mailing list <linux-kernel@vger.kernel.org>,
alexander viro <viro@parcelfarce.linux.theplanet.co.uk>,
trond myklebust <trondmy@trondhjem.org>
Subject: Re: d_splice_alias() problem.
Date: Tue, 4 May 2004 10:05:40 +1000 [thread overview]
Message-ID: <20040504000540.GB24969@sgi.com> (raw)
In-Reply-To: <16534.54704.792101.617408@cse.unsw.edu.au>
On Tue, May 04, 2004 at 09:28:48AM +1000, Neil Brown wrote:
> On Monday May 3, gnb@melbourne.sgi.com wrote:
> > Neil Brown wrote:
> > >
> > * Dentry_stat.nr_unused can be be spuriously decremented when dput()
> > races with __dget_unlocked(). Eventual result is nr_unused<0
> > and kswapd loops. This is the problem I mentioned earlier. Note
> > that this is not an NFS-specific problem. Fix is:
> >
> > --- linux.orig/fs/dcache.c Mon May 3 21:46:30 2004
> > +++ linux/fs/dcache.c Mon May 3 21:49:07 2004
> > @@ -255,8 +255,8 @@
> >
> > static inline struct dentry * __dget_locked(struct dentry *dentry)
> > {
> > - atomic_inc(&dentry->d_count);
> > - if (atomic_read(&dentry->d_count) == 1) {
> > + if (atomic_inc(&dentry->d_count) == 1) {
>
> One problem with this is that (in include/asm-i386/atomic.h at least):
> static __inline__ void atomic_inc(atomic_t *v)
>
> atomic_inc returns "void".
Doh! This is what comes from doing all coding and testing on minority
achitectures...I'll think about this a bit more.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
I don't speak for SGI.
next prev parent reply other threads:[~2004-05-04 0:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-23 13:02 d_splice_alias() problem Nikita Danilov
2004-04-23 15:40 ` Andreas Dilger
2004-04-23 16:20 ` Nikita Danilov
2004-04-23 23:49 ` Andrew Morton
2004-04-26 12:45 ` Nikita Danilov
2004-04-30 4:54 ` Neil Brown
2004-04-30 7:50 ` Greg Banks
2004-04-30 13:28 ` Nikita Danilov
2004-05-03 23:46 ` Neil Brown
2004-05-03 12:02 ` Greg Banks
2004-05-03 23:28 ` Neil Brown
2004-05-04 0:05 ` Greg Banks [this message]
2004-05-04 7:00 ` Greg Banks
2004-05-04 9:46 ` viro
2004-05-04 10:21 ` Greg Banks
2004-05-05 0:11 ` Neil Brown
2004-05-10 3:03 ` Neil Brown
2004-05-10 4:50 ` Greg Banks
2004-05-10 3:27 ` Neil Brown
2004-05-10 11:28 ` Greg Banks
2004-05-13 5:58 ` Neil Brown
2004-05-13 7:15 ` Greg Banks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040504000540.GB24969@sgi.com \
--to=gnb@sgi.com \
--cc=Nikita@Namesys.COM \
--cc=gnb@melbourne.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=trondmy@trondhjem.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox