public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Marc-Christian Petersen <m.c.p@kernel.linux-systeme.com>
Cc: linux-kernel@vger.kernel.org, Adrian Bunk <bunk@fs.tum.de>,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	davem@redhat.com
Subject: Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4
Date: Tue, 4 May 2004 16:56:59 -0400	[thread overview]
Message-ID: <20040504205659.GA17583@havoc.gtf.org> (raw)
In-Reply-To: <200405042253.11133@WOLK>

On Tue, May 04, 2004 at 10:53:11PM +0200, Marc-Christian Petersen wrote:
> On Tuesday 04 May 2004 22:46, Adrian Bunk wrote:
> 
> Hi Adrian,
> 
> > drivers/net/net.o(.text+0x60293): In function `tg3_get_strings':
> > : undefined reference to `WARN_ON'
> > make: *** [vmlinux] Error 1
> > There's no WARN_ON in 2.4.
> 
> yep. Either we backport WARN_ON ;) or simply do the attached.

I would rather add the simple patch to 2.4.x core, since tg3 isn't the
only driver that continues to be heavily used in 2.4, and thus will
continue to be actively maintained for a while...

	Jeff




  reply	other threads:[~2004-05-04 20:57 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-03 23:09 Linux 2.4.27-pre2 Marcelo Tosatti
2004-05-04  3:49 ` Frédéric L. W. Meunier
2004-05-04 19:19 ` Linux 2.4.27-pre2 (gcc-3.4.0) Rafał 'rmrmg' Roszak
     [not found]   ` <200405042146.40404@WOLK>
2004-05-04 20:03     ` Rafał 'rmrmg' Roszak
2004-05-05  6:36       ` Rene Rebe
2004-05-05  8:15         ` Rafał 'rmrmg' Roszak
2004-05-05  9:30           ` Mikael Pettersson
2004-05-05  9:53             ` Rene Rebe
2004-05-05 10:20               ` Mikael Pettersson
2004-05-04 20:46 ` 2.4.27-pre2: tg3: there's no WARN_ON in 2.4 Adrian Bunk
2004-05-04 20:53   ` Marc-Christian Petersen
2004-05-04 20:56     ` Jeff Garzik [this message]
2004-05-05  3:18       ` David S. Miller
2004-05-05  8:57         ` Marc-Christian Petersen
2004-05-05 19:30           ` David S. Miller
2004-05-04 23:44     ` Eyal Lebedinsky
2004-05-06 12:13       ` Adrian Bunk
2004-05-12  0:07         ` H. Peter Anvin
2004-05-13 22:34           ` Adrian Bunk
2004-05-13 23:03             ` H. Peter Anvin
2004-05-17  0:38               ` Adrian Bunk
2004-05-05 23:50 ` Linux 2.4.27-pre2 Eyal Lebedinsky
2004-05-07 13:49   ` Marcelo Tosatti
2004-05-19 18:14 ` [2.4 patch] hotplug: add missing Configure.help entries Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040504205659.GA17583@havoc.gtf.org \
    --to=jgarzik@pobox.com \
    --cc=bunk@fs.tum.de \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.c.p@kernel.linux-systeme.com \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox