public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marc-Christian Petersen <m.c.p@kernel.linux-systeme.com>
To: linux-kernel@vger.kernel.org
Cc: Carson Gaspar <carson@taltos.org>,
	Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	Marco Fais <marco.fais@abbeynet.it>
Subject: Re: kernel BUG at page_alloc.c:98 -- compiling with distcc
Date: Wed, 5 May 2004 18:28:55 +0200	[thread overview]
Message-ID: <200405051828.55572@WOLK> (raw)
In-Reply-To: <765880000.1083774300@taltos.ny.ficc.gs.com>

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

On Wednesday 05 May 2004 18:25, Carson Gaspar wrote:

Hi Carson,

> I'd love to. However 2.4.27-pre2 broke the tg3 driver. tg3.c contains
> WARN_ON(1). Sadly, WARN_ON doesn't exist in 2.4.x, so depmod correctly
> complains about an unresolved symbol.
> I'm beginning to wonder if anyone actually builds these pre releases... I
> mean, I know the tg3 driver is really obscure, and only used by 2 people,
> but...

by 2 people? you have to be kidding.

Anyway, attached is 2.4 WARN_ON. Apply it and use tg3 :p

ciao, Marc

[-- Attachment #2: 2.4-WARN_ON.patch --]
[-- Type: text/x-diff, Size: 472 bytes --]

--- old/include/linux/kernel.h	2004-05-04 21:48:24.000000000 +0200
+++ new/include/linux/kernel.h	2004-05-05 10:53:32.000000000 +0200
@@ -196,4 +196,11 @@ struct sysinfo {
 
 #define BUG_ON(condition) do { if (unlikely((condition)!=0)) BUG(); } while(0)
 
+#define WARN_ON(condition) do { \
+	if (unlikely((condition)!=0)) { \
+		printk("Badness in %s at %s:%d\n", __FUNCTION__, __FILE__, __LINE__); \
+		dump_stack(); \
+	} \
+} while (0)
+
 #endif /* _LINUX_KERNEL_H */

  reply	other threads:[~2004-05-05 16:31 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-02 10:21 kernel BUG at page_alloc.c:98 -- compiling with distcc Marco Fais
2004-04-02 13:15 ` Marco Roeland
     [not found]   ` <6.0.0.22.2.20040402163334.02abe7d8@pop.localnet>
2004-04-02 15:05     ` Marco Roeland
2004-04-05 10:42       ` Marco Fais
2004-04-05 11:46         ` Marco Roeland
2004-04-05 14:08           ` Marco Fais
2004-04-05 14:36             ` Marco Roeland
2004-04-05 17:03       ` Max Valdez
2004-04-02 23:36 ` Andrew Morton
2004-04-05 10:47   ` Marco Fais
2004-04-05 10:56     ` Andrew Morton
2004-04-05 13:58       ` Marco Fais
2004-05-04  1:07 ` Marcelo Tosatti
2004-05-05 16:25   ` Carson Gaspar
2004-05-05 16:28     ` Marc-Christian Petersen [this message]
2004-05-05 18:35     ` Marcelo Tosatti
2004-05-19 11:59       ` Marcelo Tosatti
2004-05-19 15:50         ` Marc-Christian Petersen
2004-05-20 12:21           ` Marcelo Tosatti
2004-05-19 20:21         ` Carson Gaspar
  -- strict thread matches above, loose matches on Subject: below --
2004-04-23 22:33 Carson Gaspar
2004-04-28  2:02 ` Jeff Moyer
2004-04-29 21:09   ` Marcelo Tosatti
2004-04-29 21:28     ` Andrew Morton
2004-04-29 22:49       ` Andrea Arcangeli
2004-04-29 23:26         ` Andrew Morton
2004-04-30  0:15           ` Andrea Arcangeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405051828.55572@WOLK \
    --to=m.c.p@kernel.linux-systeme.com \
    --cc=carson@taltos.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=marco.fais@abbeynet.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox