From: Greg KH <greg@kroah.com>
To: Hanna Linder <hannal@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, roms@lpg.ticalc.org, jb@technologeek.org
Subject: Re: [PATCH 2.6.6-rc3] Add class support to drivers/usb/misc/tiglusb.c
Date: Wed, 5 May 2004 15:35:10 -0700 [thread overview]
Message-ID: <20040505223510.GA30309@kroah.com> (raw)
In-Reply-To: <36460000.1083795831@dyn318071bld.beaverton.ibm.com>
On Wed, May 05, 2004 at 03:23:51PM -0700, Hanna Linder wrote:
> +out_class:
> + class_simple_device_remove(MKDEV(TIUSB_MAJOR, TIUSB_MINOR + s->minor));
> + class_simple_destroy(tiglusb_class);
Ick, don't destroy the whole class. Not good.
> + class_simple_device_remove(MKDEV(TIUSB_MAJOR, TIUSB_MINOR + s->minor));
> + class_simple_destroy(tiglusb_class);
Same thing here, you don't have to delete the class, only the class
device.
thanks,
greg k-h
next prev parent reply other threads:[~2004-05-05 22:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-29 19:38 [PATCH 2.6.6-rc3] Add class support to drivers/usb/misc/tiglusb.c Hanna Linder
2004-05-02 6:49 ` Greg KH
2004-05-05 22:23 ` Hanna Linder
2004-05-05 22:35 ` Greg KH [this message]
2004-05-05 23:35 ` Hanna Linder
2004-05-11 21:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040505223510.GA30309@kroah.com \
--to=greg@kroah.com \
--cc=hannal@us.ibm.com \
--cc=jb@technologeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roms@lpg.ticalc.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox