From: Matt Domsch <Matt_Domsch@dell.com>
To: Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: PCI devices with no PCI_CACHE_LINE_SIZE implemented
Date: Wed, 5 May 2004 17:48:47 -0500 [thread overview]
Message-ID: <20040505224847.GA2283@lists.us.dell.com> (raw)
In-Reply-To: <20040505223102.GF30003@kroah.com>
On Wed, May 05, 2004 at 03:31:02PM -0700, Greg KH wrote:
> On Thu, Apr 29, 2004 at 02:53:01PM -0500, Matt Domsch wrote:
> > a) need this be a warning, wouldn't KERN_DEBUG suffice, if a message
> > is needed at all? This is printed in pci_generic_prep_mwi().
>
> Yes, we should make that KERN_DEBUG. I don't have a problem with that.
> Care to make a patch?
Appended for 2.6.6-rc3. I'll send a 2.4.x patch separately.
Thanks,
Matt
--
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com
===== drivers/pci/pci.c 1.65 vs edited =====
--- 1.65/drivers/pci/pci.c Fri Mar 26 10:58:01 2004
+++ edited/drivers/pci/pci.c Wed May 5 17:39:08 2004
@@ -640,7 +640,7 @@
if (cacheline_size == pci_cache_line_size)
return 0;
- printk(KERN_WARNING "PCI: cache line size of %d is not supported "
+ printk(KERN_DEBUG "PCI: cache line size of %d is not supported "
"by device %s\n", pci_cache_line_size << 2, pci_name(dev));
return -EINVAL;
next prev parent reply other threads:[~2004-05-05 22:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-29 19:53 PCI devices with no PCI_CACHE_LINE_SIZE implemented Matt Domsch
2004-05-05 22:31 ` Greg KH
2004-05-05 22:48 ` Matt Domsch [this message]
2004-05-05 23:42 ` Greg KH
2004-05-05 22:50 ` Matt Domsch
-- strict thread matches above, loose matches on Subject: below --
2004-05-06 13:28 Matt Domsch
2004-05-06 15:45 ` Jeff Garzik
2004-05-10 10:49 ` Martin Mares
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040505224847.GA2283@lists.us.dell.com \
--to=matt_domsch@dell.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox