From: Christoph Hellwig <hch@infradead.org>
To: Arjan van de Ven <arjanv@redhat.com>
Cc: linux-kernel@vger.kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl,
akpm@osdl.org
Subject: Re: Force IDE cache flush on shutdown
Date: Thu, 6 May 2004 08:49:18 +0100 [thread overview]
Message-ID: <20040506084918.B12990@infradead.org> (raw)
In-Reply-To: <20040506070449.GA12862@devserv.devel.redhat.com>; from arjanv@redhat.com on Thu, May 06, 2004 at 09:04:49AM +0200
On Thu, May 06, 2004 at 09:04:49AM +0200, Arjan van de Ven wrote:
> +static int ide_disk_notify_reboot (struct notifier_block *this, unsigned long event, void *x)
> +{
> + ide_hwif_t *hwif;
> + ide_drive_t *drive;
> + int i, unit;
> +
> + switch (event) {
> + case SYS_HALT:
> + case SYS_POWER_OFF:
> + break;
> + default:
> + return NOTIFY_DONE;
> + }
Please don't use reboot notifiers in new driver code. The driver
model has a ->shutdown method for that.
next prev parent reply other threads:[~2004-05-06 7:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-06 7:04 Force IDE cache flush on shutdown Arjan van de Ven
2004-05-06 7:49 ` Christoph Hellwig [this message]
2004-05-06 7:50 ` Arjan van de Ven
2004-05-06 7:55 ` Christoph Hellwig
2004-05-06 10:46 ` Arjan van de Ven
2004-05-06 10:52 ` Christoph Hellwig
2004-05-06 11:33 ` Arjan van de Ven
2004-05-06 11:45 ` Nigel Cunningham
2004-05-06 11:45 ` Arjan van de Ven
2004-05-06 12:36 ` Bartlomiej Zolnierkiewicz
2004-05-07 1:08 ` Benjamin Herrenschmidt
2004-05-06 11:38 ` Bartlomiej Zolnierkiewicz
2004-05-07 1:09 ` Benjamin Herrenschmidt
2004-05-09 2:00 ` Pavel Machek
2004-05-06 7:58 ` Jens Axboe
2004-05-06 8:04 ` Arjan van de Ven
2004-05-06 8:05 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040506084918.B12990@infradead.org \
--to=hch@infradead.org \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=akpm@osdl.org \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox