Re: Force IDE cache flush on shutdown

[Arjan van de Ven <arjanv@redhat.com>]

On Thu, May 06, 2004 at 11:52:20AM +0100, Christoph Hellwig wrote:
> > +	idedisk_driver.gen_driver.shutdown = ide_drive_shutdown;
> 
> isn't idedisk_driver initialized statically somewhere?  You should probably

ok ok you win

diff -purN linux-2.6.5/drivers/ide/ide-disk.c linux/drivers/ide/ide-disk.c
--- linux-2.6.5/drivers/ide/ide-disk.c	2004-05-06 13:26:53.350284720 +0200
+++ linux/drivers/ide/ide-disk.c	2004-05-06 13:32:01.322465832 +0200
@@ -1725,6 +1725,9 @@ static ide_driver_t idedisk_driver = {
 	.drives			= LIST_HEAD_INIT(idedisk_driver.drives),
 	.start_power_step	= idedisk_start_power_step,
 	.complete_power_step	= idedisk_complete_power_step,
+	.gen_driver = {
+		.shutdown	= ide_drive_shutdown,
+	},	                                
 };
 
@@ -1820,6 +1823,23 @@ static int idedisk_revalidate_disk(struc
 	return 0;
 }
 
+static int ide_drive_shutdown(struct device * dev)
+{
+	ide_drive_t * drive = container_of(dev,ide_drive_t,gendev);
+	
+	/* safety checks */
+	if (!drive->present)
+		return 0;
+	if (drive->media != ide_disk)
+		return 0;
+	printk("Flushing cache: %s \n", drive->name);
+	ide_cacheflush_p(drive);
+	/* give the hardware time to finish; it may return prematurely to cheat */
+	mdelay(300);
+	return 0;
+}
+                        
+
 static struct block_device_operations idedisk_ops = {
 	.owner		= THIS_MODULE,
 	.open		= idedisk_open,