From: Dave Jones <davej@redhat.com>
To: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC] DMI cleanup patches
Date: Thu, 6 May 2004 12:47:59 +0100 [thread overview]
Message-ID: <20040506114759.GA27851@redhat.com> (raw)
In-Reply-To: <20040506102904.GA3295@pazke>
On Thu, May 06, 2004 at 02:29:04PM +0400, Andrey Panin wrote:
Hi Andrey,
> currently arch/i386/kernel/dmi_scan.c file looks like complete
> mess. Interfacing with other kernel subsystem made using
> ad-hoc ways, mostly with ugly global variables, additionaly
> coding style is ... not good. So these patches appear:
Very nice! I like the idea of moving bits to the actual drivers
a lot. It makes perfect sense to have apm workarounds in the
apm driver etc.
One thing that might be worth your while whilst you're getting
intimate with this code, would be to take a peek at the dmi
workarounds in 2.4 and make sure we didn't miss any.
I forward ported a bunch a few months back, but I'm not sure
if I got them all, and it's possible new ones were added there
that we missed in 2.6
Good work.
Dave
next prev parent reply other threads:[~2004-05-06 11:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-06 10:29 [RFC] DMI cleanup patches Andrey Panin
2004-05-06 11:47 ` Dave Jones [this message]
2004-05-06 14:39 ` Linus Torvalds
2004-05-06 15:10 ` Andrew Morton
2004-05-06 16:32 ` Dave Jones
2004-05-06 21:23 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040506114759.GA27851@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox