From: Rob Landley <rob@landley.net>
To: Daniele Venzano <webvenza@libero.it>, Ken Ashcraft <ken@coverity.com>
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: Re: [PATCH] sis900 fix (Was: [CHECKER] Resource leaks in driver shutdown functions)
Date: Thu, 6 May 2004 12:23:40 -0500 [thread overview]
Message-ID: <200405061223.40942.rob@landley.net> (raw)
In-Reply-To: <20040504084326.GA11133@gateway.milesteg.arr>
On Tuesday 04 May 2004 03:43, Daniele Venzano wrote:
> Thank you for the spotting, the sis900 dirver was really missing a call
> to netif_device_detach in sis900_suspend.
>
> Attached is a trivial patch that fixes the issue.
>
> The sis900 driver is currently unmaintained (the MAINTAINERS address
> bounces), but I'm willing to take the work, since I know somewhat the
> code and I wrote the power management functions.
>
> I no one stands up, I'll send a patch to MAINTAINERS later on.
>
> Bye.
Does this fix the problem where you unplug the cat 5 cable from an SiS900 and
then plug it back in (toggling the MII tranciever link detect status and all
that), and the device goes positively mental until you reboot the system?
(Packets randomly dropped or delayed for up to 15 seconds, and arriving out
of sequence with horrible impacts on performance?)
I tried pursuing this when I first noticed it circa 2.4.4, but as you say, the
driver is unmaintained and I haven't got specs (or any clue about) the
chipset...
Rob
next prev parent reply other threads:[~2004-05-06 17:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-03 18:46 [CHECKER] Resource leaks in driver shutdown functions Ken Ashcraft
2004-05-04 8:43 ` [PATCH] sis900 fix (Was: [CHECKER] Resource leaks in driver shutdown functions) Daniele Venzano
2004-05-04 15:28 ` Randy.Dunlap
2004-05-04 17:54 ` Daniele Venzano
2004-05-06 17:23 ` Rob Landley [this message]
2004-05-07 15:06 ` Daniele Venzano
2004-05-11 17:35 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200405061223.40942.rob@landley.net \
--to=rob@landley.net \
--cc=ken@coverity.com \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@rustcorp.com.au \
--cc=webvenza@libero.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox