public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* cpumask cleanup patches dont build
@ 2004-05-06 21:13 Ashok Raj
  2004-05-06 22:02 ` Paul Jackson
  0 siblings, 1 reply; 2+ messages in thread
From: Ashok Raj @ 2004-05-06 21:13 UTC (permalink / raw)
  To: pj; +Cc: akpm, linux-kernel

Hi Paul

Appears that some changes are still missed.

i ran into sched.c the following seems to fix it 


---
 
 linux-2.6.6-rc3-mm2-root/kernel/sched.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
 
diff -puN kernel/sched.c~pj_cpus_complement kernel/sched.c
--- linux-2.6.6-rc3-mm2/kernel/sched.c~pj_cpus_complement       2004-05-06 14:03:14.853689716 -0700
+++ linux-2.6.6-rc3-mm2-root/kernel/sched.c     2004-05-06 14:09:40.786504501 -0700
@@ -3666,7 +3666,7 @@ static void migrate_all_tasks(int src_cp
                        dest_cpu = any_online_cpu(tsk->cpus_allowed);
                if (dest_cpu == NR_CPUS) {
                        cpus_clear(tsk->cpus_allowed);
-                       cpus_complement(tsk->cpus_allowed);
+                       cpus_complement(tsk->cpus_allowed, tsk->cpus_allowed);
                        dest_cpu = any_online_cpu(tsk->cpus_allowed);
  
                        /* Don't tell them about moving exiting tasks


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: cpumask cleanup patches dont build
  2004-05-06 21:13 cpumask cleanup patches dont build Ashok Raj
@ 2004-05-06 22:02 ` Paul Jackson
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Jackson @ 2004-05-06 22:02 UTC (permalink / raw)
  To: Ashok Raj; +Cc: akpm, linux-kernel

Right you are - that cpus_complement was inside an ifdef
CONFIG_HOTPLUG_CPU section that was added after I did my
global searches for such calls.  And obviously, you are
the first to build this with HOTPLUG enabled.

Thanks, Ashok.

-- 
                          I won't rest till it's the best ...
                          Programmer, Linux Scalability
                          Paul Jackson <pj@sgi.com> 1.650.933.1373

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-06 21:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-06 21:13 cpumask cleanup patches dont build Ashok Raj
2004-05-06 22:02 ` Paul Jackson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox