Re: 2.6.6-rc3-mm2 (4KSTACK)

Arjan van de Ven
2004-05-07T16:01:53Z

[-- Attachment #1: Type: text/plain, Size: 413 bytes --]

On Fri, May 07, 2004 at 10:47:56AM -0500, Steve Lord wrote:
> >- if (mlen > sizeof(buf))
> >+ obj.data = kmalloc(1024, GFP_KERNEL);
> >+ if (!obj.data)
> >+ return -ENOMEM;
> >+
> >+ if (mlen > 1024) {
>
> That's what I hate about all of this, just think how much stack that
> kmalloc can take in low memory situations.... it might end up in
> writepage on another nfs file....

it clearly needs to be GFP_NOFS

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]