Re: 2.6.6-rc3-mm2 (4KSTACK)

J. Bruce Fields
2004-05-07T16:09:56Z

On Fri, May 07, 2004 at 05:59:43PM +0200, Arjan van de Ven wrote:
> On Fri, May 07, 2004 at 10:47:56AM -0500, Steve Lord wrote:
> > >- if (mlen > sizeof(buf))
> > >+ obj.data = kmalloc(1024, GFP_KERNEL);
> > >+ if (!obj.data)
> > >+ return -ENOMEM;
> > >+
> > >+ if (mlen > 1024) {
> >
> > That's what I hate about all of this, just think how much stack that
> > kmalloc can take in low memory situations.... it might end up in
> > writepage on another nfs file....
>
> it clearly needs to be GFP_NOFS

The function is question is essentially a write method for a virtual
filesystem (rpc_pipefs) that's used to communicate with some
NFSv4-related daemons. It isn't called from any of the NFS fileystem
code.

--Bruce Fields