Re: 2.6.6-rc3-mm2 (4KSTACK)

Jörn Engel
2004-05-05T21:51:47Z

On Wed, 5 May 2004 14:22:02 -0400, Valdis.Kletnieks@vt.edu wrote:
> On Wed, 05 May 2004 13:12:30 +0200, Dominik Karall <dominik.karall@gmx.net> said:
>
> > Is there any reason why this patch was applied? Because NVidia users can't
> > work with the original drivers now without removing this patch every time.
>
> The NVidia users will also have to back out the regparm patch, or insert
> 'asmlinkage' on all the appropriate definitions in the glue code. Note that
> the patches on www.minion.de already fix this for the 5341 drivers as of
> 03/24/2004.
>
> In any case, even though I'm one of those NVidia users, I'm OK with the
> patch being in there - anybody who's clued enough to build and run a -mm
> kernel shouldn't have much trouble figuring out how to build it with 2 patches
> reverted.

I disagree. -mm is the testing ground for -linus. If this patch
would only break the nvidia module, I couldn't care less. But
breaking it in such a way that random kernel memory gets corrupted,
which can soon backfire to the filesystem as well? That's not what
most people understand when calling something "stable".

If this goes in, we should at least detect the nvidia module and
refuse to load it. Maybe do the same for other modules as well or
refuse to load any module that doesn't somehow state to be ok with 4k
stacks. Details don't matter, as long as the filesystems survive.

Jörn

--
Das Aufregende am Schreiben ist es, eine Ordnung zu schaffen, wo
vorher keine existiert hat.
-- Doris Lessing