From: Christoph Hellwig <hch@infradead.org>
To: Jan Beulich <JBeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sys_ioctl export consolidation
Date: Thu, 6 May 2004 15:50:08 +0100 [thread overview]
Message-ID: <20040506155008.A17635@infradead.org> (raw)
In-Reply-To: <s09a2e2c.054@emea1-mh.id2.novell.com>; from JBeulich@novell.com on Thu, May 06, 2004 at 01:23:24PM +0200
On Thu, May 06, 2004 at 01:23:24PM +0200, Jan Beulich wrote:
> Since we noted that sys_ioctl is not currently being exported for ia64
> to be used in the 32-bit emulation routines I'd like to suggest the
> following patch, which, instead of making this available in another
> individual architecture, exports the symbol whenever CONFIG_COMPAT is
> defined (legal users should be a subset of
> [un]register_ioctl32_conversion users, which is scoped by the same
> config option).
Should ioctl32 handlers in drivers really call sys_ioctl? Calling sys_ioctl
makes sense for ioctls that are supported by a broad range of drivers, but
in that case the ioctl32 translation should be in the core compat code.
Drivers using register_ioctl32_conversion should rather call their own
ioctl handlers directly if you ask me.
Do you have a list of drivers currently needing sys_ioctl?
next prev parent reply other threads:[~2004-05-06 14:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-06 11:23 sys_ioctl export consolidation Jan Beulich
2004-05-06 14:50 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-05-06 15:49 Jan Beulich
[not found] <1SPff-rH-29@gated-at.bofh.it>
[not found] ` <1SSw7-35a-11@gated-at.bofh.it>
2004-05-07 6:17 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040506155008.A17635@infradead.org \
--to=hch@infradead.org \
--cc=JBeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox