From: Brad Boyer <flar@allandria.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux/m68k <linux-m68k@lists.linux-m68k.org>,
Linux/m68k on Mac <linux-mac68k@mac.linux-m68k.org>,
Zhenmin Li <zli4@cs.uiuc.edu>,
Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [OPERA] Potential bugs detected by static analysis tool in 2.6.4
Date: Thu, 6 May 2004 09:29:43 -0700 [thread overview]
Message-ID: <20040506162943.GA1205@pants.nu> (raw)
In-Reply-To: <Pine.GSO.4.58.0405061141290.12096@waterleaf.sonytel.be>
On Thu, May 06, 2004 at 11:43:45AM +0200, Geert Uytterhoeven wrote:
> On Wed, 5 May 2004, Zhenmin Li wrote:
> > 8. /arch/m68k/mac/iop.c, Line 164:
>
> Should be line 264?
Perhaps they cut out the comments before counting lines? There are
around 100 lines of comments at the top explaining the whole mess.
In any case, line 264 sounds right. It's shortly after
if(macintosh_config->adb_type == MAC_ADB_IOP) {
> > iop_base[IOP_NUM_SCC]->status_ctrl = 0;
> >
> > Maybe change to:
> > iop_base[IOP_NUM_ISM]->status_ctrl = 0;
>
> Mac guys, is this correct?
Actually, I think it is. It looks like this is a bug that crept in
during the last IOP rewrite (back in 2.2). It's not the same line
number in 2.2 and 2.4, but there is a similar situation. I'll see
if I can find some time to get my Mac IIfx running again and try
out a fix. I did get a 2.6 kernel running on it once before.
And as a note to the person who reported this, please include at
least a line or two of context around the change. If you use
diff -u, that's even better.
Brad Boyer
flar@allandria.com
next prev parent reply other threads:[~2004-05-06 16:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-06 3:41 [OPERA] Potential bugs detected by static analysis tool in 2.6.4 Zhenmin Li
2004-05-06 9:43 ` Geert Uytterhoeven
2004-05-06 16:29 ` Brad Boyer [this message]
2004-05-06 16:44 ` Zhenmin Li
2004-05-06 20:22 ` Brad Boyer
2004-05-07 0:14 ` Luiz Fernando N. Capitulino
2004-05-07 22:22 ` [OPERA] Another potential error detected by static analysis tool (2.6.4) Zhenmin Li
2004-05-07 23:07 ` Andreas Dilger
[not found] <002701c4331c$092a3b40$76f6ae80@Turandot.suse.lists.linux.kernel>
2004-05-06 7:14 ` [OPERA] Potential bugs detected by static analysis tool in 2.6.4 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040506162943.GA1205@pants.nu \
--to=flar@allandria.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mac68k@mac.linux-m68k.org \
--cc=zli4@cs.uiuc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox