[RFC] DMI cleanup patches

[RFC] DMI cleanup patches

[Andrey Panin]

[-- Attachment #1: Type: text/plain, Size: 1276 bytes --]

Hi all,

currently arch/i386/kernel/dmi_scan.c file looks like complete
mess. Interfacing with other kernel subsystem made using
ad-hoc ways, mostly with ugly global variables, additionaly
coding style is ... not good. So these patches appear:

	patch-dmi-1-matches - simplify DMI blacklist table by
removing the need to fill unused slots with NO_MATCH macro.

	patch-dmi-2-api - separate and export dmi_check_system()
function (along with some needed declarations) which checks given
DMI id table against system DMI data and runs callback functions 
when necessary.

	patch-dmi-3-whitespace - various coding style cleanups.

	patch-dmi-4-sonypi - make sonypi driver use dmi_check_system()
function and remove is_sony_vaio_laptop global variable.

	patch-dmi-5-apm - make APM BIOS driver use dmi_check_system()
function and move all related quirks into apm.c.

	patch-dmi-6-pciirq - make pci irq routing code use 
dmi_check_system() function and make broken_hp_bios_irq9 variable 
static.

	patch-dmi-7-smbus - make PIIX4 I2C use dmi_check_system()
function and remove is_unsafe_smbus global variable.

Please take a look.

Best regards.

-- 
Andrey Panin		| Linux and UNIX system administrator
pazke@donpac.ru		| PGP key: wwwkeys.pgp.net

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

Re: [RFC] DMI cleanup patches

[Dave Jones]

On Thu, May 06, 2004 at 02:29:04PM +0400, Andrey Panin wrote:

Hi Andrey,

 > currently arch/i386/kernel/dmi_scan.c file looks like complete
 > mess. Interfacing with other kernel subsystem made using
 > ad-hoc ways, mostly with ugly global variables, additionaly
 > coding style is ... not good. So these patches appear:

Very nice! I like the idea of moving bits to the actual drivers
a lot. It makes perfect sense to have apm workarounds in the
apm driver etc.

One thing that might be worth your while whilst you're getting
intimate with this code, would be to take a peek at the dmi
workarounds in 2.4 and make sure we didn't miss any.
I forward ported a bunch a few months back, but I'm not sure
if I got them all, and it's possible new ones were added there
that we missed in 2.6

Good work.

		Dave

Re: [RFC] DMI cleanup patches

[Linus Torvalds]

On Thu, 6 May 2004, Andrey Panin wrote:
> 
> currently arch/i386/kernel/dmi_scan.c file looks like complete
> mess. Interfacing with other kernel subsystem made using
> ad-hoc ways, mostly with ugly global variables, additionaly
> coding style is ... not good. So these patches appear:

The patches look good by me, but I'd rather leave them to after 2.6.6, 
since they seem to be cleanups rather than serious bug-fixes.

Andrew?

		Linus

Re: [RFC] DMI cleanup patches

[Andrew Morton]

Linus Torvalds <torvalds@osdl.org> wrote:
>
> 
> 
> On Thu, 6 May 2004, Andrey Panin wrote:
> > 
> > currently arch/i386/kernel/dmi_scan.c file looks like complete
> > mess. Interfacing with other kernel subsystem made using
> > ad-hoc ways, mostly with ugly global variables, additionaly
> > coding style is ... not good. So these patches appear:
> 
> The patches look good by me, but I'd rather leave them to after 2.6.6, 
> since they seem to be cleanups rather than serious bug-fixes.
> 

There is a significant amount of work pending in the DRM development tree
at http://drm.bkbits.net/drm-2.6 (which is included in -mm).  Andrey's
zeroeth patch alone tosses three rejects against it.

David, now would be a good time to start getting that code ready for a
merge.

Andrey, you should rebase your patches on top of the DRM tree, or -mm, and
copy David on the emails.

Thanks.

Re: [RFC] DMI cleanup patches

[Dave Jones]

On Thu, May 06, 2004 at 08:10:12AM -0700, Andrew Morton wrote:

 > There is a significant amount of work pending in the DRM development tree
 > at http://drm.bkbits.net/drm-2.6 (which is included in -mm).  Andrey's
 > zeroeth patch alone tosses three rejects against it.

Why on earth is the DRM stuff touching the DMI code ?

		Dave

Re: [RFC] DMI cleanup patches

[Andrew Morton]

Dave Jones <davej@redhat.com> wrote:
>
> On Thu, May 06, 2004 at 08:10:12AM -0700, Andrew Morton wrote:
> 
>  > There is a significant amount of work pending in the DRM development tree
>  > at http://drm.bkbits.net/drm-2.6 (which is included in -mm).  Andrey's
>  > zeroeth patch alone tosses three rejects against it.
> 
> Why on earth is the DRM stuff touching the DMI code ?
> 

Please note the relevant header on my email:

	Date: Thu, 6 May 2004 08:10:12 -0700

Having now had a corrective nap I can confirm that

a) I'm a twit and
b) there are still a ton of rejects against Linus's tree.

Andrey, please update and resend.