From: Brad Boyer <flar@allandria.com>
To: Zhenmin Li <zli4@cs.uiuc.edu>
Cc: "'Geert Uytterhoeven'" <geert@linux-m68k.org>,
"'Linux/m68k'" <linux-m68k@lists.linux-m68k.org>,
"'Linux/m68k on Mac'" <linux-mac68k@mac.linux-m68k.org>,
"'Linux Kernel Development'" <linux-kernel@vger.kernel.org>
Subject: Re: [OPERA] Potential bugs detected by static analysis tool in 2.6.4
Date: Thu, 6 May 2004 13:22:33 -0700 [thread overview]
Message-ID: <20040506202233.GA2003@pants.nu> (raw)
In-Reply-To: <002d01c43389$6bbbea70$76f6ae80@Turandot>
On Thu, May 06, 2004 at 11:44:37AM -0500, Zhenmin Li wrote:
> Sorry for the typo. The line number should be 264, and the context is:
>
> if (macintosh_config->adb_type == MAC_ADB_IOP) {
> if (macintosh_config->ident == MAC_MODEL_IIFX) {
> iop_base[IOP_NUM_ISM] = (struct mac_iop *)
> ISM_IOP_BASE_IIFX;
> } else {
> iop_base[IOP_NUM_ISM] = (struct mac_iop *)
> ISM_IOP_BASE_QUADRA;
> }
> iop_base[IOP_NUM_SCC]->status_ctrl = 0;
> iop_ism_present = 1;
> }
That's what I suspected. Yes, this code is broken, and line 264
should have IOP_NUM_ISM, just like the other two lines. The
current IOP driver is a bit of a hack, and I guess it just slipped
through the cracks. We rely on the chips to be mostly initialized
before we touch them as it is.
This line should be fixed as suggested, and if it breaks anything,
it's because the code was broken before, and we just didn't notice.
This driver only gets used on 3 Macintosh models, all of which are
relatively obscure.
Brad Boyer
flar@allandria.com
next prev parent reply other threads:[~2004-05-06 20:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-06 3:41 [OPERA] Potential bugs detected by static analysis tool in 2.6.4 Zhenmin Li
2004-05-06 9:43 ` Geert Uytterhoeven
2004-05-06 16:29 ` Brad Boyer
2004-05-06 16:44 ` Zhenmin Li
2004-05-06 20:22 ` Brad Boyer [this message]
2004-05-07 0:14 ` Luiz Fernando N. Capitulino
2004-05-07 22:22 ` [OPERA] Another potential error detected by static analysis tool (2.6.4) Zhenmin Li
2004-05-07 23:07 ` Andreas Dilger
[not found] <002701c4331c$092a3b40$76f6ae80@Turandot.suse.lists.linux.kernel>
2004-05-06 7:14 ` [OPERA] Potential bugs detected by static analysis tool in 2.6.4 Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040506202233.GA2003@pants.nu \
--to=flar@allandria.com \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mac68k@mac.linux-m68k.org \
--cc=zli4@cs.uiuc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox