RE: Multiple (ICH3) IDE-controllers in a system

["Shai Fultheim" <shai@ftcon.com>]

[-- Attachment #1: Type: text/plain, Size: 3049 bytes --]

Vojtech and Bartlomiej,

Attached patch that fix the problem according to (2) below.  Let me know if
you can apply it.

Thanks. 


--- linux-2.6.5-mm6.orig/arch/i386/pci/fixup.c  2004-04-29
05:23:35.000000000 -0700
+++ linux-2.6.5-mm6/arch/i386/pci/fixup.c       2004-05-07
01:45:31.000000000 -0700
@@ -92,6 +92,15 @@
        int i;
 
        /*
+        * Runs the fixup only for the first IDE controller
+        * (Shai Fultheim - shai@ftcon.com)
+        */
+       static int called = 0;
+       if (called)
+               return;
+       called = 1;
+
+       /*
         * There exist PCI IDE controllers which have utter garbage
         * in first four base registers. Ignore that.
         */



--Shai


-----Original Message-----
From: linux-ide-owner@vger.kernel.org
[mailto:linux-ide-owner@vger.kernel.org] On Behalf Of Shai Fultheim
Sent: Thursday, May 06, 2004 12:19
To: 'Vojtech Pavlik'; 'Bartlomiej Zolnierkiewicz'
Cc: linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: RE: Multiple (ICH3) IDE-controllers in a system

Ok.
I would suggest one of the followings:
1. If we can't identify those machine, I would recommend to drop that patch,
since probably the BIOS is taking care of it nowadays.
2. If we believe we can't do (1) above, lets have it rest only the first
controller it is being called for.  This will make any of the other
controllers usable if their ports are set right.

Any comments?
 

--Shai


-----Original Message-----
From: linux-ide-owner@vger.kernel.org
[mailto:linux-ide-owner@vger.kernel.org] On Behalf Of Vojtech Pavlik
Sent: Wednesday, May 05, 2004 23:46
To: Bartlomiej Zolnierkiewicz
Cc: shai@ftcon.com; linux-ide@vger.kernel.org; linux-kernel@vger.kernel.org
Subject: Re: Multiple (ICH3) IDE-controllers in a system

On Wed, May 05, 2004 at 05:16:43PM +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi Vojtech,
> 
> Do I correctly assume that these fixups for Intel chipsets are from you?

Yes.

>
http://linus.bkbits.net:8080/linux-2.5/cset@3cfbacdfzHvfqp0Sa45QXt9pNn3LNg?n
av=index.html|src/|src/arch|src/arch/i386|src/arch/i386/pci|related/arch/i38
6/pci/fixup.c
>
http://linus.bkbits.net:8080/linux-2.5/cset@3cfcec0fOJreGFyCWkPeT7EWiydYFw?n
av=index.html|src/|src/arch|src/arch/i386|src/arch/i386/pci|related/arch/i38
6/pci/fixup.c
> 
> Care to explain why 'trash' fixup is needed in 2.6 but not in 2.4?

Because 2.4 was never used on the affected machines, where this fixup
was needed - those machines sere putting nonsense into the BARs. I don't
recall exactly what model they were, though I remember they were one of
the first machines with ICH MMIO support.

-- 
Vojtech Pavlik
SuSE Labs, SuSE CR
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: pci-ide-fixup.patch --]
[-- Type: application/octet-stream, Size: 499 bytes --]

--- linux-2.6.5-mm6.orig/arch/i386/pci/fixup.c	2004-04-29 05:23:35.000000000 -0700
+++ linux-2.6.5-mm6/arch/i386/pci/fixup.c	2004-05-07 01:45:31.000000000 -0700
@@ -92,6 +92,15 @@
 	int i;
 
 	/*
+	 * Runs the fixup only for the first IDE controller
+	 * (Shai Fultheim - shai@ftcon.com)
+	 */
+	static int called = 0;
+	if (called)
+		return;
+	called = 1;
+
+	/*
 	 * There exist PCI IDE controllers which have utter garbage
 	 * in first four base registers. Ignore that.
 	 */