public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: Ari Pollak <ajp@aripollak.com>
Subject: Re: 2.6.6-rc3-mm2 oops in psmouse/serio after resuming from APM suspend-to-ram
Date: Mon, 10 May 2004 00:40:40 -0500	[thread overview]
Message-ID: <200405100040.51116.dtor_core@ameritech.net> (raw)
In-Reply-To: <c7j8vk$rhf$1@sea.gmane.org>

On Saturday 08 May 2004 01:30 pm, Ari Pollak wrote:
> This patch did indeed fix the problem; thanks! Hopefully it will be in 
> the next -mm update.
>

Actually the previous patch is a bad one, I think this one is better:

===================================================================


ChangeSet@1.1620, 2004-05-10 00:33:57-05:00, dtor_core@ameritech.net
  Input: do not call synaptics_init unless we are ready to do full
         mouse setup


 psmouse-base.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)


===================================================================



diff -Nru a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
--- a/drivers/input/mouse/psmouse-base.c	Mon May 10 00:35:11 2004
+++ b/drivers/input/mouse/psmouse-base.c	Mon May 10 00:35:11 2004
@@ -427,7 +427,7 @@
 		}
 
 		if (max_proto > PSMOUSE_IMEX) {
-			if (synaptics_init(psmouse) == 0)
+			if (!set_properties || synaptics_init(psmouse) == 0)
 				return PSMOUSE_SYNAPTICS;
 /*
  * Some Synaptics touchpads can emulate extended protocols (like IMPS/2).

  reply	other threads:[~2004-05-10  5:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-07 20:18 2.6.6-rc3-mm2 oops in psmouse/serio after resuming from APM suspend-to-ram Ari Pollak
2004-05-07 22:16 ` Dmitry Torokhov
2004-05-08 18:30   ` Ari Pollak
2004-05-10  5:40     ` Dmitry Torokhov [this message]
2004-05-08 21:34   ` Ari Pollak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405100040.51116.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=ajp@aripollak.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox