Re: 2.6.6-rc3-mm2

[Andi Kleen <ak@muc.de>]

On Mon, May 10, 2004 at 08:16:53AM +1000, Rusty Russell wrote:
> On Sun, 2004-05-09 at 23:32, Andi Kleen wrote:
> > It is all the fault of Move-saved_command_line-to-init-mainc.patch
> > which unfortunately has been in -mm* for some time.
> > 
> > It simply breaks all boot arguments on x86-64.
> 
> How about debugging a known problem instead of whining how your arch was
> broken by a simple change required to consolidate early parameter
> parsing sanely?

I did that, found that your patch causes the breakage, reverted it 
and it worked again. Sorry I don't have time right now to hunt
for bugs in your patches.

Frankly such cleanups are more something for 2.7 anyways, they seem
to be misplaced currently when we're all else trying to stabilize 2.6.
After all it does not fix any bugs, just adds new ones.
 
> I suspect that the problem is caused by x86_64 not saving the
> commandline correctly, and this change has merely made the bug worse.

I am not aware of any x86-64 command line problems without your
patches.
> 
> You copy the command line to saved_command_line twice: once in head64.c
> and once in setup.c.  Why?  In head64.c you don't terminate it, in
> setup.c you do.  Which is right?  There are printks of

It should be already terminated, the additional termination in 
setup.c was probably just paranoia (It was inherited from i386)

The second copy could be probably dropped, but I am not touching
this code with a bargepole right now.

> I don't have an x86_64 box, and I ask *again* if someone who does can
> take a look at the problem...

I would propose you defer these patches to 2.7 and then we try again.
Hopefully there will be more time then to hunt issues in all kinds
of cleanup patches.

-Andi