From: viro@parcelfarce.linux.theplanet.co.uk
To: Paul Eggert <eggert@CS.UCLA.EDU>
Cc: Jon Oberheide <jon@focalhost.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org, bug-patch@gnu.org,
bug-gnu-utils@gnu.org
Subject: Re: [PATCH] [RFC] adding support for .patches and /proc/patches.gz
Date: Mon, 10 May 2004 19:51:07 +0100 [thread overview]
Message-ID: <20040510185107.GD17014@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <87oeowb029.fsf@penguin.cs.ucla.edu>
On Mon, May 10, 2004 at 11:37:34AM -0700, Paul Eggert wrote:
> Jon Oberheide <jon@focalhost.com> writes:
>
> > I'm CC'ing this to the GNU patch maintainers. Hopefully they will have
> > some input.
>
> As I understand it, Solution 4 is an incompatible change to 'patch'
> which would cause 'patch' to not conform to POSIX, the LSB, or to
> widespread existing practice. That's a pretty serious step, and I'm
> not sure it's worth the aggravation.
>
> Solution 3 would be to add an option to 'patch' to cause it to log the
> patches into a file. The basic idea seems like a worthwhile
> improvement to 'patch', though (as you mention) it's more of a hassle
> for users to remember the option.
>
> Perhaps there's a better way to address the problem in a way that
> maintains compatibility while still satisfying your needs. For example,
> if the kernel patches all contained a line like this at the start:
>
> Patch-log: .patches
>
> then 'patch' could log all the changes into the named file. This
> would conform to POSIX.
Not needed.
diff -erN dir1/file dir2/file
--- dir1/file
+++ dir2/file
1i
lines
.
will do just fine. Remember that patch(1) can handle at least some ed
scripts.
next prev parent reply other threads:[~2004-05-10 18:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-10 2:48 [PATCH] [RFC] adding support for .patches and /proc/patches.gz Jon Oberheide
2004-05-10 18:37 ` Paul Eggert
2004-05-10 18:51 ` viro [this message]
2004-05-11 9:34 ` Jan-Benedict Glaw
2004-05-11 18:37 ` Bill Davidsen
2004-05-12 4:59 ` Jon Oberheide
2004-05-12 8:28 ` Cef (LKML)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040510185107.GD17014@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=bug-gnu-utils@gnu.org \
--cc=bug-patch@gnu.org \
--cc=eggert@CS.UCLA.EDU \
--cc=jon@focalhost.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox