From: Paul Mundt <lethal@linux-sh.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: shemminger@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Fix 8139too ring size for dreamcast/embedded
Date: Tue, 11 May 2004 08:54:05 -0400 [thread overview]
Message-ID: <20040511125405.GA14578@linux-sh.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1366 bytes --]
Presently 2.6.6 backs out the CONFIG_8139_RXBUF_IDX in favor of using a
hardcoded 8139_RXBUF_IDX (again). This seems to have been done due to
some issues occuring with 8139_RXBUF_IDX == 3, however (as the Kconfig
pointed out), we still need 8139_RXBUF_IDX == 1 in the CONFIG_SH_DREAMCAST
case.
The patch which made this change can be seen at:
http://linux.bkbits.net:8080/linux-2.5/user=shemminger/cset@1.1371.719.67?nav=!-|index.html|stats|!+|index.html|ChangeSet@-8w
Before that, CONFIG_8139_RXBUF_IDX was set to 1 both in the CONFIG_SH_DREAMCAST
and CONFIG_EMBEDDED cases. This patch adds that back into the current 8139too.
Additionally, why remove the config option at all? Wouldn't it just be
easier to drop the range from 0 - 3 to 0 - 2 until problems with a 64K ring
size are resolved?
--- linux-2.6.6/drivers/net/8139too.c.orig Tue May 11 08:36:24 2004
+++ linux-2.6.6/drivers/net/8139too.c Tue May 11 08:36:29 2004
@@ -171,7 +171,11 @@
* Receive ring size
* Warning: 64K ring has hardware issues and may lock up.
*/
+#if defined(CONFIG_SH_DREAMCAST) || defined(CONFIG_EMBEDDED)
+#define RX_BUF_IDX 1 /* 16K ring */
+#else
#define RX_BUF_IDX 2 /* 32K ring */
+#endif
#define RX_BUF_LEN (8192 << RX_BUF_IDX)
#define RX_BUF_PAD 16
#define RX_BUF_WRAP_PAD 2048 /* spare padding to handle lack of packet wrap */
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next reply other threads:[~2004-05-11 12:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-11 12:54 Paul Mundt [this message]
2004-05-20 2:18 ` [PATCH] Fix 8139too ring size for dreamcast/embedded Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040511125405.GA14578@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox