From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263138AbUEKSag (ORCPT ); Tue, 11 May 2004 14:30:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263107AbUEKSag (ORCPT ); Tue, 11 May 2004 14:30:36 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:56289 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S263032AbUEKSae (ORCPT ); Tue, 11 May 2004 14:30:34 -0400 Date: Tue, 11 May 2004 20:30:13 +0200 From: Jens Axboe To: Ricky Beam Cc: Bob Tracy , Kurt Garloff , Linux SCSI list , Linux kernel list Subject: Re: [PATCH] Format Unit can take many hours Message-ID: <20040511183013.GC14789@suse.de> References: <20040511162822.C46BFDBDB@gherkin.frus.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11 2004, Ricky Beam wrote: > On Tue, 11 May 2004, Bob Tracy wrote: > >Moreover, it simply "feels" wrong to define a constant for something > >that isn't... The quick fix of increasing the timeout doesn't address > >the underlying issue of how long a format should take, and as Ricky > >implies, that's probably more the concern of the application rather > >than the driver. > > The real problem is a lack of being able to specify a timeout for user > supplied commands. In-kernel drivers can set a command timeout. The > IOCTL interface does not export that capability. Noone should use that interface, period. That ioctl is about as bad an interface as you could imagine. Use any variant of sg and you should be fine. -- Jens Axboe