From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: geoff@linux.jf.intel.com, linux-kernel@vger.kernel.org,
kenneth.w.chen@intel.com
Subject: Re: [RFC] [PATCH] Performance of del_timer_sync
Date: Tue, 11 May 2004 22:26:57 +0200 [thread overview]
Message-ID: <20040511202657.GA5900@elte.hu> (raw)
In-Reply-To: <20040511131137.2390ffa8.akpm@osdl.org>
* Andrew Morton <akpm@osdl.org> wrote:
> Ah, OK, the timer handler may re-add itself. Really, that's a bug in
> the caller: once they've decided to shoot down the timer the caller
> should have made state changes which prevent the handler from
> re-adding the timer.
>
> Still, too late to change that.
yeah.
> Neither AIO nor schedule_timeout() actually re-add the timer so they
> don't need the full treatment, yes?
correct.
> +int del_single_shot_timer(struct timer_struct *timer)
> +{
> + if (del_timer(timer))
> + del_timer_sync(timer);
> +}
cool, this looks good to me. It's obviously correct and has a limited
scope. (I'd suggest another name though: del_timer_singleshot(). This i
think fits into the existing naming better: del_timer() and
del_timer_sync(). But no strong feelings either way.)
Ingo
next prev parent reply other threads:[~2004-05-11 20:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-10 22:16 [RFC] [PATCH] Performance of del_timer_sync Geoff Gustafson
2004-05-11 7:45 ` Andrew Morton
2004-05-11 18:36 ` Geoff Gustafson
2004-05-11 19:11 ` Andrew Morton
2004-05-11 19:23 ` Chen, Kenneth W
2004-05-11 19:28 ` Andrew Morton
2004-05-11 19:30 ` Andrew Morton
2004-05-11 19:58 ` Ingo Molnar
2004-05-11 20:11 ` Andrew Morton
2004-05-11 20:19 ` Christoph Hellwig
2004-05-11 20:26 ` Andrew Morton
2004-05-11 20:32 ` Ingo Molnar
2004-05-11 20:55 ` Andrew Morton
2004-05-11 20:57 ` Ingo Molnar
2004-05-11 21:01 ` Chen, Kenneth W
2004-05-11 20:26 ` Ingo Molnar [this message]
2004-05-11 20:27 ` Chen, Kenneth W
2004-05-11 20:30 ` Andrew Morton
2004-05-11 20:45 ` Chen, Kenneth W
2004-05-11 20:38 ` Ingo Molnar
-- strict thread matches above, loose matches on Subject: below --
2004-05-11 22:46 Geoff Gustafson
[not found] <40A152A8.4080104@linux.intel.com>
2004-05-11 23:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040511202657.GA5900@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=geoff@linux.jf.intel.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox