From: Greg KH <greg@kroah.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: airlied@pdx.freedesktop.org
Subject: Re: From Eric Anholt:
Date: Tue, 11 May 2004 15:22:45 -0700 [thread overview]
Message-ID: <20040511222245.GA25644@kroah.com> (raw)
In-Reply-To: <200405112211.i4BMBQDZ006167@hera.kernel.org>
On Sat, Apr 10, 2004 at 04:32:02AM +0000, Linux Kernel Mailing List wrote:
> diff -Nru a/drivers/char/drm/drm.h b/drivers/char/drm/drm.h
> --- a/drivers/char/drm/drm.h Tue May 11 15:11:32 2004
> +++ b/drivers/char/drm/drm.h Tue May 11 15:11:32 2004
> @@ -580,6 +580,16 @@
> unsigned long handle; /**< Used for mapping / unmapping */
> } drm_scatter_gather_t;
>
> +/**
> + * DRM_IOCTL_SET_VERSION ioctl argument type.
> + */
> +typedef struct drm_set_version {
> + int drm_di_major;
> + int drm_di_minor;
> + int drm_dd_major;
> + int drm_dd_minor;
> +} drm_set_version_t;
> +
Ick, you can't use "int" as an ioctl structure member, sorry. Please
use the proper "__u16" or "__u32" value instead.
And what about kernels running in 64bit mode with 32bit userspace? Care
to provide the proper thunking layer for them too?
thanks,
greg k-h
next parent reply other threads:[~2004-05-11 22:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200405112211.i4BMBQDZ006167@hera.kernel.org>
2004-05-11 22:22 ` Greg KH [this message]
2004-05-11 23:17 ` From Eric Anholt: Dave Airlie
2004-05-11 23:20 ` Dave Airlie
2004-05-11 23:34 ` Valdis.Kletnieks
2004-05-11 23:43 ` Greg KH
2004-05-12 0:07 ` Daniel Jacobowitz
2004-05-12 0:12 ` Greg KH
2004-05-12 0:12 ` H. Peter Anvin
2004-05-11 23:46 ` ioctls in drm.h Dave Airlie
2004-05-13 1:39 ` From Eric Anholt: Eric Anholt
2004-05-12 1:07 ` Jon Smirl
2004-05-12 1:15 ` Greg KH
2004-05-12 22:32 ` Linus Torvalds
2004-05-13 16:54 ` Egbert Eich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040511222245.GA25644@kroah.com \
--to=greg@kroah.com \
--cc=airlied@pdx.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox