* Re: [tony@atomide.com: [PATCH] Powernow-k8 buggy BIOS override for 2.6.6]
[not found] <20040513001628.GA9388@atomide.com>
@ 2004-05-13 14:05 ` Dave Jones
2004-05-13 15:34 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2004-05-13 14:05 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-kernel, pavel
On Wed, May 12, 2004 at 05:16:28PM -0700, Tony Lindgren wrote:
> Following is the updated patch to make the powernow-k8 driver work on
> machines with buggy BIOS, such as emachines m6805.
>
> The patch overrides the PST table only if check_pst_table() fails.
>
> The minimum value for the override is 800MHz, which is the lowest value
> on all x86_64 systems AFAIK. The max value is the current running value.
>
> This patch should be safe to apply, even if Pavel's ACPI table check is
> added to the driver. Or does anybody see a problem with it?
Does the ACPI fallback not do the right thing ?
I don't really see the point of limping along with a 2-state PST
if we can derive the proper info from the ACPI table.
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [tony@atomide.com: [PATCH] Powernow-k8 buggy BIOS override for 2.6.6]
2004-05-13 14:05 ` [tony@atomide.com: [PATCH] Powernow-k8 buggy BIOS override for 2.6.6] Dave Jones
@ 2004-05-13 15:34 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2004-05-13 15:34 UTC (permalink / raw)
To: Dave Jones, linux-kernel, pavel; +Cc: cpufreq
* Dave Jones <davej@redhat.com> [040513 07:06]:
> On Wed, May 12, 2004 at 05:16:28PM -0700, Tony Lindgren wrote:
>
> > Following is the updated patch to make the powernow-k8 driver work on
> > machines with buggy BIOS, such as emachines m6805.
> >
> > The patch overrides the PST table only if check_pst_table() fails.
> >
> > The minimum value for the override is 800MHz, which is the lowest value
> > on all x86_64 systems AFAIK. The max value is the current running value.
> >
> > This patch should be safe to apply, even if Pavel's ACPI table check is
> > added to the driver. Or does anybody see a problem with it?
>
> Does the ACPI fallback not do the right thing ?
Does not work for me. But looks like that's because I had to turn off
ACPI processor module since 2.6.6 since it would hang my system. It could
also be that the hang is caused by the powernow-k8. I will check that.
> I don't really see the point of limping along with a 2-state PST
> if we can derive the proper info from the ACPI table.
Sure if the ACPI table check works properly. But even with 2-state PST,
being able to change from 1800MHz to 800MHz on battery increases the
battery life quite a bit. And it does not necessarily require ACPI :)
Regards,
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-05-13 15:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20040513001628.GA9388@atomide.com>
2004-05-13 14:05 ` [tony@atomide.com: [PATCH] Powernow-k8 buggy BIOS override for 2.6.6] Dave Jones
2004-05-13 15:34 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox