From: Vincent Hanquez <tab@snarc.org>
To: Brian Gerst <bgerst@didntduck.org>
Cc: Andrew Morton <akpm@osdl.org>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Remove hardcoded offsets from i386 asm
Date: Fri, 14 May 2004 08:28:55 +0200 [thread overview]
Message-ID: <20040514062855.GA8842@snarc.org> (raw)
In-Reply-To: <40A4318A.2050504@quark.didntduck.org>
[-- Attachment #1: Type: text/plain, Size: 427 bytes --]
On Thu, May 13, 2004 at 10:40:10PM -0400, Brian Gerst wrote:
> Generate offsets for thread_info, cpuinfo_x86, and a few others instead
> of hardcoding them.
Hi Brian,
why not keeping all macro name in uppercase ?
the patch would look a lot smaller, and as the macro got the same
meaning, I don't see why the name should change.
> - movl TI_FLAGS(%ebp), %ecx
> + movl TI_flags(%ebp), %ecx
Cheers,
--
Tab
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-05-14 6:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-14 2:40 [PATCH] Remove hardcoded offsets from i386 asm Brian Gerst
2004-05-14 6:28 ` Vincent Hanquez [this message]
2004-05-14 13:29 ` Brian Gerst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040514062855.GA8842@snarc.org \
--to=tab@snarc.org \
--cc=akpm@osdl.org \
--cc=bgerst@didntduck.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox