From: Adrian Bunk <bunk@fs.tum.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.4.27-pre2: tg3: there's no WARN_ON in 2.4
Date: Mon, 17 May 2004 02:38:09 +0200 [thread overview]
Message-ID: <20040517003808.GS22742@fs.tum.de> (raw)
In-Reply-To: <40A3FEB3.3050800@zytor.com>
On Thu, May 13, 2004 at 04:03:15PM -0700, H. Peter Anvin wrote:
> Adrian Bunk wrote:
> >>
> >AFAIR, the -tiny tree already implements some kind of empty
> >BUG/PAGE_BUG/WARN_ON macros.
> >
> >When optimizing for size that way, your suggestion would result in
> >bigger code.
> >
>
> ?!?!?!?!?!
>
> If there are no side effects, my suggestion produces zero code.
>
> >And after a quick view, I haven't seen any WARN_ON users in 2.6 that
> >seem to rely on side effects.
>
> Then there should be no size difference, either.
Ah thanks, now I do understand it.
> -hpa
Thanks
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-05-17 0:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-03 23:09 Linux 2.4.27-pre2 Marcelo Tosatti
2004-05-04 3:49 ` Frédéric L. W. Meunier
2004-05-04 19:19 ` Linux 2.4.27-pre2 (gcc-3.4.0) Rafał 'rmrmg' Roszak
[not found] ` <200405042146.40404@WOLK>
2004-05-04 20:03 ` Rafał 'rmrmg' Roszak
2004-05-05 6:36 ` Rene Rebe
2004-05-05 8:15 ` Rafał 'rmrmg' Roszak
2004-05-05 9:30 ` Mikael Pettersson
2004-05-05 9:53 ` Rene Rebe
2004-05-05 10:20 ` Mikael Pettersson
2004-05-04 20:46 ` 2.4.27-pre2: tg3: there's no WARN_ON in 2.4 Adrian Bunk
2004-05-04 20:53 ` Marc-Christian Petersen
2004-05-04 20:56 ` Jeff Garzik
2004-05-05 3:18 ` David S. Miller
2004-05-05 8:57 ` Marc-Christian Petersen
2004-05-05 19:30 ` David S. Miller
2004-05-04 23:44 ` Eyal Lebedinsky
2004-05-06 12:13 ` Adrian Bunk
2004-05-12 0:07 ` H. Peter Anvin
2004-05-13 22:34 ` Adrian Bunk
2004-05-13 23:03 ` H. Peter Anvin
2004-05-17 0:38 ` Adrian Bunk [this message]
2004-05-05 23:50 ` Linux 2.4.27-pre2 Eyal Lebedinsky
2004-05-07 13:49 ` Marcelo Tosatti
2004-05-19 18:14 ` [2.4 patch] hotplug: add missing Configure.help entries Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040517003808.GS22742@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox