Re: 2.6.6 : bad PCI device ID for SiS ISA bridge => SiS900 eth0: Can not find ISA bridge

David Dillow
2004-05-17T03:50:25Z

On Sun, 2004-05-16 at 17:47, Jeff Garzik wrote:
> Eric BENARD / Free wrote:
> > 1- bad PCI device ID for SiS ISA bridge
> >
> > 2- In 2.6.3-rc2 (and 2.4.x), the PCI device ID of the ISA bridge of the
> > SiS630e is 0x0008. This ID is used by sis900.c in order to get the MAC
> > adress.
> > In 2.6.6, the PCI device ID of the ISA bridge of the SiS630E is 0x0018. The
> > SiS900 driver fail to read MAC adress and exit with the following message :
> > eth0: Can not find ISA bridge
> [...]
[...]
> I'm not sure I understand your message.
>
> Are you suggesting
> a) the hardware PCI id changed from 0x0008 to 0x0018 when booting 2.6.6.
> or
> b) sis900.c changed when booting 2.6.6.
>
> If "a", the PCI id in sis900.c seems to be 0x0008 in both 2.4 and 2.6.
> And further, I did not see any changes to this line of code in while
> searching 2.6.2 -> 2.6.6 patches on ftp.kernel.org. I would lean
> towards a solution that modified sis900.c to check for -both- 0x08 and 0x18.

I'm not sure I understand the message, either. I can confirm that SiS's
LPC-to-ISA bridges can change their device ID based on writes to the PCI
config space -- 0x08 and 0x18 are both valid ids for that hardware.

Eric, if you'll send me an lspci -xxx on the ISA bridge run under both
kernels, that may be interesting. Then the fun part will be finding what
changed in the kernel to cause that.

In any event, I think it would be valid to have sis900 check for both
ids.

Dave