public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Maneesh Soni <maneesh@in.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Greg KH <greg@kroah.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [2.6.6-mm3] sysfs backing store ver 0.6
Date: Mon, 17 May 2004 17:34:43 +0530	[thread overview]
Message-ID: <20040517120443.GB1249@in.ibm.com> (raw)

Hello Andrew,

Please find the following patch set for sysfs backing store for 2.6.6-mm3 
kernel. I have fixed the rejects and there are also a few code changes.

The main change is related to providing protection against vulnerability of 
parent dentry going off before the sysfs file being deleted. If you have 
seen there was a oops message reported with 2.6.6-mm1 in which parent 
dentry's ref count is zero when it was trying to remove a sysfs link.

http://marc.theaimsgroup.com/?l=linux-kernel&m=108422899203505&w=2

The changes I did are in fs/sysfs/inode.c:sysfs_hash_and_remove() and
sysfs_remove_dir(), where it is now checking s_dentry field of the 
corresponding sysfs_dirent to get the dentry (if valid) of the file 
being deleted. Apart from being safe against parent dentry going off 
before the child, this change also avoids allocating the dentry in the 
removal path by not doing the lookup. 

Please include the following patches in the next -mm and also note that they
all depend on the fix-sysfs-symlinks.patch, I just mailed.
http://marc.theaimsgroup.com/?l=linux-kernel&m=108479506507825&w=2

Thanks
Maneesh

-- 
Maneesh Soni
Linux Technology Center, 
IBM Software Lab, Bangalore, India
email: maneesh@in.ibm.com
Phone: 91-80-25044999 Fax: 91-80-25268553
T/L : 9243696

             reply	other threads:[~2004-05-17 12:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-17 12:04 Maneesh Soni [this message]
2004-05-17 12:05 ` [2.6.6-mm3] sysfs-leaves-mount.patch Maneesh Soni
2004-05-17 12:06   ` [2.6.6-mm3] sysfs-leaves-dir.patch Maneesh Soni
2004-05-17 12:06     ` [2.6.6-mm3] sysfs-leaves-file.patch Maneesh Soni
2004-05-17 12:07       ` [2.6.6-mm3] sysfs-leaves-bin.patch Maneesh Soni
2004-05-17 12:07         ` [2.6.6-mm3] sysfs-leaves-symlink.patch Maneesh Soni
2004-05-17 12:08           ` [2.6.6-mm3] sysfs-leaves-misc.patch Maneesh Soni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040517120443.GB1249@in.ibm.com \
    --to=maneesh@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox