From: Mathieu Chouquet-Stringer <mchouque@online.fr>
To: linux-kernel@vger.kernel.org, rth@twiddle.net,
linux-alpha@vger.kernel.org, ralf@gnu.org,
linux-mips@linux-mips.org, akpm@osdl.org, bjornw@axis.com,
dev-etrax@axis.com, mikael.starvik@axis.com, sam@ravnborg.org
Subject: Re: [PATCH] Fix for 2.6.6 Makefiles to get KBUILD_OUTPUT working
Date: Mon, 17 May 2004 11:23:11 -0400 [thread overview]
Message-ID: <20040517152311.GA29999@localhost> (raw)
In-Reply-To: <20040516203322.GA4784@mars.ravnborg.org>
On Sun, May 16, 2004 at 10:33:22PM +0200, Sam Ravnborg wrote:
> > --- arch/mips/Makefile.orig 2004-05-15 20:48:52.000000000 -0400
> > +++ arch/mips/Makefile 2004-05-15 20:49:58.000000000 -0400
> >
> > -makeboot =$(Q)$(MAKE) -f scripts/Makefile.build obj=arch/mips/boot $(1)
> > +makeboot =$(Q)$(MAKE) $(build)=arch/mips/boot $(1)
>
> Please get rid of makeboot. Use $(Q)$(MAKE) ... instead.
> Hereby the '+' sign is no longer needed (used today where makeboot is used.
Ok, I applied the changes you requested, please check the diff for mips as
I had to modify some other lines too.
--- arch/alpha/Makefile.orig 2004-05-15 20:46:06.000000000 -0400
+++ arch/alpha/Makefile 2004-05-15 20:47:52.000000000 -0400
@@ -106,10 +106,10 @@ boot := arch/alpha/boot
all boot: $(boot)/vmlinux.gz
$(boot)/vmlinux.gz: vmlinux
- $(Q)$(MAKE) -f scripts/Makefile.build obj=$(boot) $@
+ $(Q)$(MAKE) $(build)=$(boot) $@
bootimage bootpfile bootpzfile: vmlinux
- $(Q)$(MAKE) -f scripts/Makefile.build obj=$(boot) $(boot)/$@
+ $(Q)$(MAKE) $(build)=$(boot) $(boot)/$@
prepare: include/asm-$(ARCH)/asm_offsets.h
@@ -121,8 +121,8 @@ include/asm-$(ARCH)/asm_offsets.h: arch/
$(call filechk,gen-asm-offsets)
archclean:
- $(Q)$(MAKE) -f scripts/Makefile.clean obj=$(boot)
+ $(Q)$(MAKE) $(clean)=$(boot)
CLEAN_FILES += include/asm-$(ARCH)/asm_offsets.h
--- arch/mips/Makefile.orig 2004-05-15 20:48:52.000000000 -0400
+++ arch/mips/Makefile 2004-05-17 11:11:57.000000000 -0400
@@ -686,8 +686,6 @@ vmlinux.64: vmlinux
--change-addresses=0xa800000080000000 $< $@
endif
-makeboot =$(Q)$(MAKE) -f scripts/Makefile.build obj=arch/mips/boot $(1)
-
ifdef CONFIG_SGI_IP27
all: vmlinux.64
endif
@@ -697,10 +695,10 @@ all: vmlinux.ecoff
endif
vmlinux.ecoff vmlinux.rm200: vmlinux
- +@$(call makeboot,$@)
+ $(Q)$(MAKE) $(build)=arch/mips/boot $@
vmlinux.srec: vmlinux
- +@$(call makeboot,$@)
+ $(Q)$(MAKE) $(build)=arch/mips/boot $@
CLEAN_FILES += vmlinux.ecoff \
vmlinux.srec \
@@ -708,10 +706,10 @@ CLEAN_FILES += vmlinux.ecoff \
vmlinux.rm200
archclean:
- @$(MAKE) -f scripts/Makefile.clean obj=arch/mips/boot
- @$(MAKE) -f scripts/Makefile.clean obj=arch/mips/baget
- @$(MAKE) -f scripts/Makefile.clean obj=arch/mips/lasat
+ $(Q)$(MAKE) $(clean)=arch/mips/boot
+ $(Q)$(MAKE) $(clean)=arch/mips/baget
+ $(Q)$(MAKE) $(clean)=arch/mips/lasat
# Generate <asm/offset.h
#
--- arch/sh/boot/Makefile.orig 2004-05-15 20:50:11.000000000 -0400
+++ arch/sh/boot/Makefile 2004-05-15 20:50:41.000000000 -0400
@@ -16,5 +16,5 @@ $(obj)/zImage: $(obj)/compressed/vmlinux
@echo 'Kernel: $@ is ready'
$(obj)/compressed/vmlinux: FORCE
- $(Q)$(MAKE) -f scripts/Makefile.build obj=$(obj)/compressed $@
+ $(Q)$(MAKE) $(build)=$(obj)/compressed $@
--- arch/cris/Makefile.orig 2004-05-15 20:59:49.000000000 -0400
+++ arch/cris/Makefile 2004-05-15 21:00:36.000000000 -0400
@@ -81,7 +81,7 @@ compressed: zImage
archmrproper:
archclean:
- $(Q)$(MAKE) -f scripts/Makefile.clean obj=arch/$(ARCH)/boot
+ $(Q)$(MAKE) $(clean)=arch/$(ARCH)/boot
rm -f timage vmlinux.bin cramfs.img
rm -rf $(LD_SCRIPT).tmp
--
Mathieu Chouquet-Stringer E-Mail: mchouque@online.fr
Never attribute to malice that which can be adequately
explained by stupidity.
-- Hanlon's Razor --
prev parent reply other threads:[~2004-05-17 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-16 1:22 [PATCH] Fix for 2.6.6 Makefiles to get KBUILD_OUTPUT working Mathieu Chouquet-Stringer
2004-05-16 20:33 ` Sam Ravnborg
2004-05-17 15:23 ` Mathieu Chouquet-Stringer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040517152311.GA29999@localhost \
--to=mchouque@online.fr \
--cc=akpm@osdl.org \
--cc=bjornw@axis.com \
--cc=dev-etrax@axis.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mikael.starvik@axis.com \
--cc=ralf@gnu.org \
--cc=rth@twiddle.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox