Re: 1352 NUL bytes at the end of a page? (was Re: Assertion `s && s->tree' failed: The saga continues.)

Steven Cole
2004-05-17T22:16:53Z

On Monday 17 May 2004 03:29 pm, Andrew Morton wrote:
> Steven Cole <elenstev@mesatop.com> wrote:
> >
> > 1) Apply your patch to 2.6.6-current, build with PREEMPT
> > 2) Test bk pull via ppp on reiserfs until and if it breaks.
> > 3) Test bk pull via ppp on ext3 and take a look at the s.ChangeSet file
> > if/when the failure occurs.
> > 4) Apply akpm's patch here:
> > http://marc.theaimsgroup.com/?l=linux-kernel&m=108478018304305&w=2
> > 5) Repeat 2,3
>
> Nope. Please just see if this makes the problem go away:
>
> --- 25/fs/buffer.c~a Mon May 17 14:28:51 2004
> +++ 25-akpm/fs/buffer.c Mon May 17 14:29:02 2004
> @@ -2723,7 +2723,6 @@ int block_write_full_page(struct page *p
> * writes to that region are not written out to the file."
> */
> kaddr = kmap_atomic(page, KM_USER0);
> - memset(kaddr + offset, 0, PAGE_CACHE_SIZE - offset);
> flush_dcache_page(page);
> kunmap_atomic(kaddr, KM_USER0);
> return __block_write_full_page(inode, page, get_block, wbc);
>
> _
>
> If this patch is confirmed to fix things up, then and only then should you
> bother testing the vmtruncate patch.
>
> Thanks.
>
>

Thank you very much Andrew. Building now.

Steven