From: Greg KH <greg@kroah.com>
To: Oliver Neukum <oliver@neukum.org>
Cc: linux-usb-devel@lists.sourceforge.net,
Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [linux-usb-devel] Re: usb sleep patch
Date: Tue, 18 May 2004 12:53:09 -0700 [thread overview]
Message-ID: <20040518195309.GA15058@kroah.com> (raw)
In-Reply-To: <200405182146.54806.oliver@neukum.org>
On Tue, May 18, 2004 at 09:46:54PM +0200, Oliver Neukum wrote:
>
> > + * msleep - sleep safely even with waitqueue interruptions
> > + * msecs: Time in milliseconds to sleep for
> > + */
> > +static inline void msleep(unsigned int msecs)
>
> Why do you make it inline? After a milisecond the cache is cold,
> so we should shrink the code.
I wasn't thinking, see my final proposed patch.
thanks,
greg k-h
prev parent reply other threads:[~2004-05-18 19:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <40AA3A0E.5040500@pobox.com>
[not found] ` <20040518171625.GB12348@kroah.com>
2004-05-18 19:46 ` [linux-usb-devel] Re: usb sleep patch Oliver Neukum
2004-05-18 19:53 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040518195309.GA15058@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox