* Re: [linux-usb-devel] Re: usb sleep patch [not found] ` <20040518171625.GB12348@kroah.com> @ 2004-05-18 19:46 ` Oliver Neukum 2004-05-18 19:53 ` Greg KH 0 siblings, 1 reply; 2+ messages in thread From: Oliver Neukum @ 2004-05-18 19:46 UTC (permalink / raw) To: linux-usb-devel; +Cc: Greg KH, Jeff Garzik, Andrew Morton, Linux Kernel > + * msleep - sleep safely even with waitqueue interruptions > + * msecs: Time in milliseconds to sleep for > + */ > +static inline void msleep(unsigned int msecs) Why do you make it inline? After a milisecond the cache is cold, so we should shrink the code. Regards Oliver ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [linux-usb-devel] Re: usb sleep patch 2004-05-18 19:46 ` [linux-usb-devel] Re: usb sleep patch Oliver Neukum @ 2004-05-18 19:53 ` Greg KH 0 siblings, 0 replies; 2+ messages in thread From: Greg KH @ 2004-05-18 19:53 UTC (permalink / raw) To: Oliver Neukum; +Cc: linux-usb-devel, Jeff Garzik, Andrew Morton, Linux Kernel On Tue, May 18, 2004 at 09:46:54PM +0200, Oliver Neukum wrote: > > > + * msleep - sleep safely even with waitqueue interruptions > > + * msecs: Time in milliseconds to sleep for > > + */ > > +static inline void msleep(unsigned int msecs) > > Why do you make it inline? After a milisecond the cache is cold, > so we should shrink the code. I wasn't thinking, see my final proposed patch. thanks, greg k-h ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-05-18 19:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <40AA3A0E.5040500@pobox.com>
[not found] ` <20040518171625.GB12348@kroah.com>
2004-05-18 19:46 ` [linux-usb-devel] Re: usb sleep patch Oliver Neukum
2004-05-18 19:53 ` Greg KH
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox