public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor_core@ameritech.net>
To: linux-kernel@vger.kernel.org
Cc: John Zielinski <grim@undead.cc>
Subject: Re: [RFC] sysfs kobject that doesn't trigger hotplug events
Date: Tue, 18 May 2004 22:18:19 -0500	[thread overview]
Message-ID: <200405182218.20987.dtor_core@ameritech.net> (raw)
In-Reply-To: <40AAC26C.2080803@undead.cc>

On Tuesday 18 May 2004 09:11 pm, John Zielinski wrote:
> I'm adding some data structures to a device and want them to appear 
> under that device in sysfs in subdirectories.  These data structures are 
> linked together in a tree like layout so it would make sense to have 
> them have a subdirectory tree representing them.  These data structures 
> have a kobject for reference counting and I can use kobject_add and 
> kobject_del to add them to the sysfs tree.
> 
> Looking through the kobject.c code I noticed that this would create a 
> lot of hotplug events which would burn up a bit of processor time.  
> These events are not necessary as these are not device kobjects.  I've 
> enclosed a patch to my solution for this.  I'd like to know if there are 
> any side effects with this method.
> 

You are wasting 4 bytes for every kobject out there. Just implement your
private hotplug callback that would return something like -ENODEV so the
hotplug helper would not be called. If needed you can call kobject_hotplug
later, when you are ready. 

-- 
Dmitry

  reply	other threads:[~2004-05-19  5:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-19  2:11 [RFC] sysfs kobject that doesn't trigger hotplug events John Zielinski
2004-05-19  3:18 ` Dmitry Torokhov [this message]
2004-05-21  1:19   ` John Zielinski
2004-05-19  3:34 ` Greg KH
2004-05-19  4:43   ` John Zielinski
2004-05-19  5:16     ` Greg KH
2004-05-22  1:38       ` John Zielinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200405182218.20987.dtor_core@ameritech.net \
    --to=dtor_core@ameritech.net \
    --cc=grim@undead.cc \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox