Re: [PATCH] Remove bogus WARN_ON in futex_wait

[Muli Ben-Yehuda <mulix@mulix.org>]

[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]

On Wed, May 19, 2004 at 12:23:50PM +0200, Andi Kleen wrote:
> 
> futex_wait goes to an interruptible sleep, but does a WARN_ON later
> if it wakes up early. But waking up early is totally legal, since
> the sleep is interruptible and any signal can wake it up.

That's not what the WARN_ON is saynig, unless I'm missing
something. It's checking if we were woken up early and there's no
signal pending for us. 

Cheers, 
Muli 

> Remove the WARN_ON checking for that.
> 
> diff -u linux/kernel/Makefile-o linux/kernel/Makefile
> diff -u linux/kernel/futex.c-o linux/kernel/futex.c
> --- linux/kernel/futex.c-o	2004-03-21 21:12:13.000000000 +0100
> +++ linux/kernel/futex.c	2004-05-19 10:01:02.000000000 +0200
> @@ -504,8 +504,6 @@
>  		return 0;
>  	if (time == 0)
>  		return -ETIMEDOUT;
> -	/* A spurious wakeup should never happen. */
> -	WARN_ON(!signal_pending(current));
>  	return -EINTR;
>  
>   out_unqueue:
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Muli Ben-Yehuda
http://www.mulix.org | http://mulix.livejournal.com/


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]