Re: [PATCH] Remove bogus WARN_ON in futex_wait

Andi Kleen
2004-05-20T08:43:13Z

On Thu, 20 May 2004 10:52:46 +1000
Rusty Russell <rusty@rustcorp.com.au> wrote:

> Which we've been trying to figure out. We return -EINTR in this case
> even though it's a lie. Don't know if it breaks anything, but I
> *really* want to know who the buggy waker is before pronouncing it
> harmless.

e.g. from ptrace, like Daniel said. I don't think it was from ptrace
in the case where I saw a report, but it shows that the WARN_ON is bogus.
If you really want to know what causes it you would need more debugging code
as Nick pointed out too. So, the WARN_ON in its current form
is known to trigger in a valid situation and not sufficient to find
possible problems. I would remove it.

-Andi