Re: [2.4 patch] Re: CONFIG_ATALK cannot be compiled as a module

[Oliver Feiler <kiza@gmx.net>]

[-- Attachment #1: signed data --]
[-- Type: text/plain, Size: 1513 bytes --]

Hi Adrian,

sorry for the late reply, didn't find time to test it earlier.

On Tuesday 11 May 2004 01:53, Adrian Bunk wrote:

> > > > when selecting CONFIG_ATALK as a module the symbols
> > > > register_snap_client and unregister_snap_client will be unresolved.
> > > > As I understand it they are in net/802/psnap.c which does not get
> > > > compiled when Appletalk is selected as a module. Compiling into the
> > > > kernel works fine.
> > > >...

> The patch below that should fix it.
>
> diffstat output:
>  net/802/Makefile |   60 ++++++++++++++---------------------------------
>  net/Makefile     |    2 -
>  2 files changed, 20 insertions(+), 42 deletions(-)
>
> patch description:
> - net/Makefile: there might be modules in net/802/
> - net/802/Makefile: deuglyfy it and make it more similar to the
>                     2.6 version

Yes, works fine. No unresolved symbols.

FWIW, the modules psnap.o and p8022.o don't export a license and taint the 
kernel:

Warning: loading /lib/modules/2.4.26/kernel/net/802/p8022.o will taint the 
kernel: no license
  See http://www.tux.org/lkml/#export-tainted for information about tainted 
modules
Module p8022 loaded, with warnings
Warning: loading /lib/modules/2.4.26/kernel/net/802/psnap.o will taint the 
kernel: no license
Module psnap loaded, with warnings
Module appletalk loaded, with warnings


Other than that it works for me. Thanks for your help!

	Oliver

-- 
Oliver Feiler  -  http://kiza.kcore.de/

[-- Attachment #2: signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]