From: Jeff Sipek <jeffpc@optonline.net>
To: matthieu castet <castet.matthieu@free.fr>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch] bug in cpuid & msr on nosmp machine
Date: Wed, 19 May 2004 22:44:55 -0400 [thread overview]
Message-ID: <200405192245.07235.jeffpc@optonline.net> (raw)
In-Reply-To: <40AB8CDF.8060408@free.fr>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Wednesday 19 May 2004 12:35, matthieu castet wrote:
> hi,
>
> on monocpu machine (and maybe even on smp machine), when you try to
> acces to a cpu that don't exist (/dev/cpu/1/cpuid), cpuid (msr) call
> cpu_online, but on nosmp machine if the cpu!=0 this procude a BUG();
> So I add a check that verify if the cpu can exist before calling
> cpu_online.
Added a check? I think your patch is reversed.
Jeff.
- - if (cpu >= num_possible_cpus() || !cpu_online(cpu))
+ if (!cpu_online(cpu))
return -ENXIO; /* No such CPU */
- --
Hegh QaQ law'
quvHa'ghach QaQ puS
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)
iD8DBQFArBuwwFP0+seVj/4RArcUAJwNIuZ6RhDYaHfnLIjKkiyXrXjfgwCgytvY
hpqUVuBbNwragYDMkjNOm4w=
=8DZk
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2004-05-20 2:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-19 16:35 [patch] bug in cpuid & msr on nosmp machine matthieu castet
2004-05-19 17:46 ` matthieu castet
2004-05-20 2:44 ` Jeff Sipek [this message]
2004-05-20 9:51 ` Paul Jackson
2004-05-20 7:32 ` Andrew Morton
2004-05-20 8:34 ` Rusty Russell
2004-05-20 8:51 ` Andrew Morton
2004-05-20 9:30 ` Rusty Russell
2004-05-20 9:57 ` Rusty Russell
[not found] <1XCh4-1jO-67@gated-at.bofh.it>
[not found] ` <1XRg3-4LW-31@gated-at.bofh.it>
[not found] ` <1XRg3-4LW-29@gated-at.bofh.it>
[not found] ` <1XSc3-5y3-23@gated-at.bofh.it>
2004-05-22 8:13 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200405192245.07235.jeffpc@optonline.net \
--to=jeffpc@optonline.net \
--cc=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox