From: Andi Kleen <ak@suse.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: mulix@mulix.org, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] Remove bogus WARN_ON in futex_wait
Date: Thu, 20 May 2004 10:41:43 +0200 [thread overview]
Message-ID: <20040520104143.6830f81b.ak@suse.de> (raw)
In-Reply-To: <1085013927.7624.5.camel@bach>
On Thu, 20 May 2004 10:52:46 +1000
Rusty Russell <rusty@rustcorp.com.au> wrote:
> Which we've been trying to figure out. We return -EINTR in this case
> even though it's a lie. Don't know if it breaks anything, but I
> *really* want to know who the buggy waker is before pronouncing it
> harmless.
e.g. from ptrace, like Daniel said. I don't think it was from ptrace
in the case where I saw a report, but it shows that the WARN_ON is bogus.
If you really want to know what causes it you would need more debugging code
as Nick pointed out too. So, the WARN_ON in its current form
is known to trigger in a valid situation and not sufficient to find
possible problems. I would remove it.
-Andi
prev parent reply other threads:[~2004-05-20 8:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-19 10:23 [PATCH] Remove bogus WARN_ON in futex_wait Andi Kleen
2004-05-19 10:43 ` Muli Ben-Yehuda
2004-05-19 10:50 ` Andi Kleen
2004-05-19 10:54 ` Muli Ben-Yehuda
2004-05-19 11:07 ` Nick Piggin
2004-05-19 14:42 ` Daniel Jacobowitz
2004-05-20 0:52 ` Rusty Russell
2004-05-20 8:41 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040520104143.6830f81b.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mulix@mulix.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox