From: Pavel Machek <pavel@ucw.cz>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: swsusp: fix swsusp with intel-agp
Date: Fri, 21 May 2004 13:41:25 +0200 [thread overview]
Message-ID: <20040521114125.GA10052@elf.ucw.cz> (raw)
In-Reply-To: <20040521112209.GA951@gondor.apana.org.au>
Hi!
> > > > > --- tmp/linux/arch/i386/mm/init.c 2004-05-20 23:08:05.000000000 +0200
> > > > > +++ linux/arch/i386/mm/init.c 2004-05-20 23:10:50.000000000 +0200
> > > > > @@ -331,6 +331,13 @@
> > > > > void zap_low_mappings (void)
> > > > > {
> > > > > int i;
> > > > > +
> > > > > +#ifdef CONFIG_SOFTWARE_SUSPEND
> > > >
> > > > Can you please define this for CONFIG_PM_DISK as well? Alternatively,
> > > > you can do the same as you did in cpu.c and define this for
> > > > CONFIG_PM.
>
> Would you object to a patch that converted current uses of
> CONFIG_SOFTWARE_SUSPEND/CONFIG_PM to a new symbol that is
> turned on iff one of CONFIG_SOFTWARE_SUSPEND/CONFIG_PM_DISK
> is enabled?
I guess that open-coding #if defined() || defined() is right thing to
do for now.
Suspend2 when/if merged might not need this... This one is not really
specific to suspend-to-disk. It is specific to swsusp way of doing
things, which happens to be same as pmdisk way of doing it...
Pavel
--
934a471f20d6580d5aad759bf0d97ddc
next prev parent reply other threads:[~2004-05-21 11:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-21 10:07 swsusp: fix swsusp with intel-agp Pavel Machek
2004-05-21 11:05 ` Herbert Xu
2004-05-21 11:16 ` Pavel Machek
2004-05-21 11:18 ` Herbert Xu
2004-05-21 11:22 ` Herbert Xu
2004-05-21 11:41 ` Pavel Machek [this message]
2004-05-21 11:48 ` Herbert Xu
2004-05-21 11:51 ` Pavel Machek
2004-05-21 13:06 ` Nigel Cunningham
2004-05-21 13:19 ` Pavel Machek
2004-05-21 13:18 ` Nigel Cunningham
2004-05-21 13:26 ` Herbert Xu
2004-05-21 13:22 ` Herbert Xu
2004-05-21 11:23 ` swsusp vs. pmdisk [was Re: swsusp: fix swsusp with intel-agp] Pavel Machek
2004-05-21 11:25 ` Herbert Xu
2004-05-21 11:49 ` Pavel Machek
2004-05-22 2:10 ` swsusp: fix swsusp with intel-agp Andrew Morton
2004-05-21 23:20 ` Andrew Morton
2004-05-23 17:54 ` Pavel Machek
2004-05-23 20:08 ` Andrew Morton
2004-05-23 20:24 ` Pavel Machek
2004-05-23 21:27 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040521114125.GA10052@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox