From: a.othieno@bluewin.ch (Arthur Othieno)
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors()
Date: Fri, 21 May 2004 21:59:34 +0200 [thread overview]
Message-ID: <20040521195934.GA17681@mars> (raw)
Hi,
We're prematurely pampering the request queue before
checking whether it was indeed allocated successfully.
Against 2.6.6. Thanks.
floppy.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/block/floppy.c 2004-05-20 23:48:04.000000000 +0200
+++ b/drivers/block/floppy.c 2004-05-21 21:29:33.000000000 +0200
@@ -4271,11 +4271,11 @@
goto out;
floppy_queue = blk_init_queue(do_fd_request, &floppy_lock);
- blk_queue_max_sectors(floppy_queue, 64);
if (!floppy_queue) {
err = -ENOMEM;
goto fail_queue;
}
+ blk_queue_max_sectors(floppy_queue, 64);
blk_register_region(MKDEV(FLOPPY_MAJOR, 0), 256, THIS_MODULE,
floppy_find, NULL, NULL);
next reply other threads:[~2004-05-21 20:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-21 19:59 Arthur Othieno [this message]
2004-05-21 20:04 ` [PATCH 2.6] drivers/block/floppy.c: Premature blk_queue_max_sectors() Jeff Garzik
2004-05-21 20:10 ` Zwane Mwaikambo
2004-05-21 20:33 ` Luiz Fernando N. Capitulino
2004-05-21 20:51 ` Arthur Othieno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040521195934.GA17681@mars \
--to=a.othieno@bluewin.ch \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox