From: Arjan van de Ven <arjanv@redhat.com>
To: Willy Tarreau <willy@w.ods.org>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: i486 emu in mainline?
Date: Sun, 23 May 2004 11:13:56 +0200 [thread overview]
Message-ID: <20040523091356.GD5889@devserv.devel.redhat.com> (raw)
In-Reply-To: <20040523084415.GB16071@alpha.home.local>
[-- Attachment #1: Type: text/plain, Size: 569 bytes --]
On Sun, May 23, 2004 at 10:44:15AM +0200, Willy Tarreau wrote:
> Hi Arjan,
>
> On Sun, May 23, 2004 at 09:13:20AM +0200, Arjan van de Ven wrote:
> > on first look it seems to be missing a bunch of get_user() calls and
> > does direct access instead....
>
> It was intentional for speed purpose. The areas are checked once with
> verify_area() when we need to access memory, then data is copied directly
> from/to memory. I don't think there's any risk, but I can be wrong.
it's an oopsable offence; nothing is making sure the memory is actually
present for example.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2004-05-23 9:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-22 23:40 i486 emu in mainline? Christoph Hellwig
2004-05-23 0:20 ` Rene Rebe
2004-05-23 7:13 ` Arjan van de Ven
2004-05-23 8:44 ` Willy Tarreau
2004-05-23 9:13 ` Arjan van de Ven [this message]
2004-05-23 9:48 ` Willy Tarreau
2004-05-23 9:58 ` Arjan van de Ven
2004-05-23 11:49 ` Helge Hafting
2004-05-23 9:20 ` Andrew Morton
2004-05-23 17:11 ` Brian Gerst
2004-05-24 2:47 ` Herbert Xu
2004-05-27 21:03 ` Pavel Machek
2004-05-23 8:29 ` Willy Tarreau
2004-05-23 11:08 ` Alan Cox
2004-05-23 11:57 ` Willy Tarreau
2004-05-23 13:15 ` Alan Cox
2004-05-24 15:17 ` Jan-Benedict Glaw
2004-05-24 17:41 ` Alan Cox
2004-05-25 9:36 ` Jan-Benedict Glaw
2004-05-25 13:48 ` Alan Cox
[not found] ` <20040523105130.GA588@samarkand.rivenstone.net>
2004-05-23 11:59 ` Willy Tarreau
2004-05-24 9:08 ` P
2004-05-23 15:18 ` Jeff Garzik
2004-05-23 21:14 ` Alan Cox
2004-05-24 12:28 ` Maciej W. Rozycki
2004-05-25 17:21 ` Kronos
-- strict thread matches above, loose matches on Subject: below --
2004-05-25 17:03 Albert Cahalan
2004-05-25 22:43 ` Alan Cox
2004-10-10 20:33 Nathanael Nerode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040523091356.GD5889@devserv.devel.redhat.com \
--to=arjanv@redhat.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@w.ods.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox