Re: i486 emu in mainline?

Arjan van de Ven
2004-05-23T09:14:23Z

[-- Attachment #1: Type: text/plain, Size: 569 bytes --]

On Sun, May 23, 2004 at 10:44:15AM +0200, Willy Tarreau wrote:
> Hi Arjan,
>
> On Sun, May 23, 2004 at 09:13:20AM +0200, Arjan van de Ven wrote:
> > on first look it seems to be missing a bunch of get_user() calls and
> > does direct access instead....
>
> It was intentional for speed purpose. The areas are checked once with
> verify_area() when we need to access memory, then data is copied directly
> from/to memory. I don't think there's any risk, but I can be wrong.

it's an oopsable offence; nothing is making sure the memory is actually
present for example.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]