Re: i486 emu in mainline?

Brian Gerst
2004-05-23T17:11:29Z

Willy Tarreau wrote:
> Hi Arjan,
>
> On Sun, May 23, 2004 at 09:13:20AM +0200, Arjan van de Ven wrote:
>
>>on first look it seems to be missing a bunch of get_user() calls and
>>does direct access instead....
>
>
> It was intentional for speed purpose. The areas are checked once with
> verify_area() when we need to access memory, then data is copied directly
> from/to memory. I don't think there's any risk, but I can be wrong.

Which will break with 4G/4G. You must use at least __get_user().

--
Brian Gerst