public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: "Cef (LKML)" <cef-lkml@optusnet.com.au>
Cc: linux-kernel@vger.kernel.org, "Randy.Dunlap" <rddunlap@osdl.org>
Subject: Re: [announce/OT] kerneltop ver. 0.7
Date: Sun, 23 May 2004 23:00:07 -0700	[thread overview]
Message-ID: <20040524060007.GN1833@holomorphy.com> (raw)
In-Reply-To: <200405241553.44114.cef-lkml@optusnet.com.au>

On Mon, May 24, 2004 at 03:53:42PM +1000, Cef (LKML) wrote:
> Looks good! A few suggestions....
> Might want to add support for /boot/System.map containing the version number 
> (eg: /boot/System.map-`uname -r` ), if /boot/System.map doesn't exist, before 
> just dropping out with an error.
> For clarity, you might want to invert the "address  function ....." line to 
> separate the header from the actual displayed data (like top does).
> Having the total up in the header instead of at the end of the data might also 
> be useful (eg: next to ticks perhaps?) as it's really a waste of a display 
> line for 1 number.
> Also a little more verbosity in the error messages would be good. 
> eg:
>  /proc/profile not found:
>  You need to enable profiling support in your kernel to use kerneltop
>  /proc/profile Permission Denied:
>  You need to be root to run kerneltop
> Hope these comments are useful.

Please try the patch I just posted which eliminates the need to be root.


-- wli

  reply	other threads:[~2004-05-24  6:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-24  4:50 [announce/OT] kerneltop ver. 0.7 Randy.Dunlap
2004-05-24  5:31 ` William Lee Irwin III
2004-05-24  9:55   ` Cef (LKML)
2004-05-24 21:49     ` Randy.Dunlap
2004-05-24 21:47   ` Randy.Dunlap
2004-05-24  5:53 ` Cef (LKML)
2004-05-24  6:00   ` William Lee Irwin III [this message]
2004-05-24  7:18     ` Cef (LKML)
2004-05-25 19:12     ` Pavel Machek
  -- strict thread matches above, loose matches on Subject: below --
2004-05-24 23:20 Albert Cahalan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040524060007.GN1833@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=cef-lkml@optusnet.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rddunlap@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox