From: Jens Axboe <axboe@suse.de>
To: "Peter J. Braam" <braam@clusterfs.com>
Cc: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
"'Phil Schwan'" <phil@clusterfs.com>
Subject: Re: [PATCH/RFC] Lustre VFS patch
Date: Mon, 24 May 2004 13:46:50 +0200 [thread overview]
Message-ID: <20040524114650.GV1952@suse.de> (raw)
In-Reply-To: <20040524114009.96CE13100E2@moraine.clusterfs.com>
On Mon, May 24 2004, Peter J. Braam wrote:
> dev_read_only-vanilla-2.6.patch
>
> This introduces an ioctl on block devices to stop doing I/O. The
> only purpose of the patch is automated recovery regression testing,
> it is very convenient to have this available.
You still keep pushing this on, without having clarified why you can't
just use the genhd functions for this instead of adding some array of
block_devices. And while you fixed the bio->bi_rw check, you still don't
indicate error when you call bio_endio() for this case. So submitter of
that io thinks it completes successfully, while you just tossed it away.
Irk.
--
Jens Axboe
next prev parent reply other threads:[~2004-05-24 11:47 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-24 11:39 [PATCH/RFC] Lustre VFS patch Peter J. Braam
2004-05-24 11:46 ` Jens Axboe [this message]
2004-05-25 1:48 ` braam
2004-05-25 6:47 ` Jens Axboe
2004-05-25 8:21 ` braam
2004-05-25 8:27 ` Jens Axboe
2004-05-25 10:52 ` Lars Marowsky-Bree
2004-05-25 11:45 ` braam
2004-05-25 13:35 ` Kevin Corry
2004-05-25 13:55 ` Jens Axboe
2004-05-24 12:00 ` hch
2004-05-24 12:01 ` hch
2004-05-24 12:03 ` hch
2004-05-24 15:33 ` Horst von Brand
2004-05-25 20:43 ` hch
2004-05-24 12:05 ` hch
2004-05-24 18:06 ` Trond Myklebust
2004-05-25 8:21 ` braam
2004-05-24 12:08 ` hch
2004-05-24 13:44 ` Arjan van de Ven
2004-05-24 13:53 ` viro
2004-05-28 16:56 ` braam
2004-05-28 17:00 ` Christoph Hellwig
2004-05-24 14:19 ` viro
2004-05-28 23:18 ` Maneesh Soni
2004-05-29 17:53 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040524114650.GV1952@suse.de \
--to=axboe@suse.de \
--cc=akpm@osdl.org \
--cc=braam@clusterfs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@clusterfs.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox