Re: [linux-usb-devel] [PATCH] visor: Fix Oops on disconnect

jkroon
2004-05-21T20:01:51Z

> I've made all of the changes that recommended below. If it looks like
> I've missed anything, please indicate so.
>
>

[snip]

>>
>>>+ if (num_ports <= 0 || num_ports > 2) {
>>
>>
>> I like the idea of this check, but you are trying to test for a negative
>> value on a __u16 variable, which is always unsigned. So that check will
>> never be true :)

What happens if num_ports == 0? Not that hardware should ever report that.

[snip]