From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S265013AbUEYR4G (ORCPT ); Tue, 25 May 2004 13:56:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265011AbUEYR4F (ORCPT ); Tue, 25 May 2004 13:56:05 -0400 Received: from mx1.redhat.com ([66.187.233.31]:49861 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S265010AbUEYRzq (ORCPT ); Tue, 25 May 2004 13:55:46 -0400 Date: Tue, 25 May 2004 10:54:42 -0700 From: "David S. Miller" To: Linus Torvalds Cc: wesolows@foobazco.org, willy@debian.org, andrea@suse.de, benh@kernel.crashing.org, akpm@osdl.org, linux-kernel@vger.kernel.org, mingo@elte.hu, bcrl@kvack.org, linux-mm@kvack.org, linux-arch@vger.kernel.org Subject: Re: [PATCH] ppc64: Fix possible race with set_pte on a present PTE Message-Id: <20040525105442.2ebdc355.davem@redhat.com> In-Reply-To: References: <1085369393.15315.28.camel@gaston> <1085371988.15281.38.camel@gaston> <1085373839.14969.42.camel@gaston> <20040525034326.GT29378@dualathlon.random> <20040525114437.GC29154@parcelfarce.linux.theplanet.co.uk> <20040525153501.GA19465@foobazco.org> <20040525102547.35207879.davem@redhat.com> X-Mailer: Sylpheed version 0.9.10 (GTK+ 1.2.10; sparc-unknown-linux-gnu) X-Face: "_;p5u5aPsO,_Vsx"^v-pEq09'CU4&Dc1$fQExov$62l60cgCc%FnIwD=.UF^a>?5'9Kn[;433QFVV9M..2eN.@4ZWPGbdi<=?[:T>y?SD(R*-3It"Vj:)"dP Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 May 2004 10:49:21 -0700 (PDT) Linus Torvalds wrote: > So what I can tell, the fix is really something like this (this does both > x86 and ppc64 just to show how two different approaches would handle it, > but I have literally _tested_ neither). > > What do people think? So on sparc32 sun4m we'd implement ptep_update_dirty_accessed() with some kind of loop using the swap instruction? That's in fact what I've always wanted, someway to easily integrate the usage of such a loop so that we could handle this problem on such systems. Keith?