From: hch@infradead.org
To: Horst von Brand <vonbrand@inf.utfsm.cl>
Cc: "Peter J. Braam" <braam@clusterfs.com>,
torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org,
"'Phil Schwan'" <phil@clusterfs.com>
Subject: Re: [PATCH/RFC] Lustre VFS patch
Date: Tue, 25 May 2004 16:43:05 -0400 [thread overview]
Message-ID: <20040525204305.GA17448@infradead.org> (raw)
In-Reply-To: <200405241533.i4OFXnI01224@pincoya.inf.utfsm.cl>
On Mon, May 24, 2004 at 11:33:49AM -0400, Horst von Brand wrote:
> Won't you also need a non-__ version, perhaps like so:
>
> void d_rehash(struct dentry *entry)
> {
> spin_lock(&dcache_lock);
> __d_rehash(entry);
> spin_unlock(&dcache_lock);
> }
> EXPORT_SYMBOL(d_rehash);
>
> ?
Yes, and that is in fact included in their patch, I just didn't
quote it because it didn't seem relevant for the review.
One more reason why review requests for an url to a tarball of patches
are evil..
next prev parent reply other threads:[~2004-05-25 20:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-24 11:39 [PATCH/RFC] Lustre VFS patch Peter J. Braam
2004-05-24 11:46 ` Jens Axboe
2004-05-25 1:48 ` braam
2004-05-25 6:47 ` Jens Axboe
2004-05-25 8:21 ` braam
2004-05-25 8:27 ` Jens Axboe
2004-05-25 10:52 ` Lars Marowsky-Bree
2004-05-25 11:45 ` braam
2004-05-25 13:35 ` Kevin Corry
2004-05-25 13:55 ` Jens Axboe
2004-05-24 12:00 ` hch
2004-05-24 12:01 ` hch
2004-05-24 12:03 ` hch
2004-05-24 15:33 ` Horst von Brand
2004-05-25 20:43 ` hch [this message]
2004-05-24 12:05 ` hch
2004-05-24 18:06 ` Trond Myklebust
2004-05-25 8:21 ` braam
2004-05-24 12:08 ` hch
2004-05-24 13:44 ` Arjan van de Ven
2004-05-24 13:53 ` viro
2004-05-28 16:56 ` braam
2004-05-28 17:00 ` Christoph Hellwig
2004-05-24 14:19 ` viro
2004-05-28 23:18 ` Maneesh Soni
2004-05-29 17:53 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040525204305.GA17448@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=braam@clusterfs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phil@clusterfs.com \
--cc=torvalds@osdl.org \
--cc=vonbrand@inf.utfsm.cl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox