From: viro@parcelfarce.linux.theplanet.co.uk
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, olh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: very low performance on SCSI disks if device node is in tmpfs
Date: Wed, 26 May 2004 01:10:33 +0100 [thread overview]
Message-ID: <20040526001033.GA12308@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <Pine.LNX.4.58.0405251703000.9951@ppc970.osdl.org>
On Tue, May 25, 2004 at 05:05:46PM -0700, Linus Torvalds wrote:
>
>
> On Tue, 25 May 2004, Andrew Morton wrote:
> >
> > We need to set file->f_ra _after_ calling blkdev_open(), when inode->i_mapping
> > points at the right thing. And we need to get it from
> > inode->i_mapping->host->i_mapping too, which represents the underlying device.
>
> Hmm.. Is f_mapping is guaranteed to be non-NULL? At least for the O_DIRECT
> case, we explicitly test for f_mapping being non-NULL, although that test
> is quite possibly bogus. Maybe we should fix that too?
->f_mapping should never be NULL after successive open().
next prev parent reply other threads:[~2004-05-26 0:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-25 18:47 very low performance on SCSI disks if device node is in tmpfs Olaf Hering
2004-05-25 19:14 ` Richard B. Johnson
2004-05-25 19:34 ` Olaf Hering
2004-05-25 19:44 ` Richard B. Johnson
2004-05-25 20:02 ` Oliver Neukum
2004-05-25 21:48 ` Andrew Morton
2004-05-25 21:57 ` Richard B. Johnson
2004-05-25 21:59 ` Andrew Morton
2004-05-25 22:41 ` Andrew Morton
2004-05-26 0:05 ` Linus Torvalds
2004-05-26 0:10 ` viro [this message]
2004-05-26 0:14 ` Andrew Morton
2004-05-26 9:53 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040526001033.GA12308@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox